while adding/removing security groups to instance, checking power state of instance is not required

[boddepalli srikanth]

For instacne in non-running state, unable to add/remove security group due to below conditon.

$ compute/api.py:

    def add_to_instance(self, context, instance, security_group_name):
           .....
           if instance['power_state'] != power_state.RUNNING: <<<<<
                 raise exception.InstanceNotRunning(instance_id=instance_uuid)
           ....

   def remove_from_instance(self, context, instance, security_group_name):
           .....
           if instance['power_state'] != power_state.RUNNING: <<<<<
                 raise exception.InstanceNotRunning(instance_id=instance_uuid)
           ....

Is it required?

[Vish Ishaya (vishvananda)]

I don't believe this is required.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24550

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24550
Committed: http://github.com/openstack/nova/commit/074f64cd67b96f31b9e43299b633e9df71450f59
Submitter: Jenkins
Branch: master

commit 074f64cd67b96f31b9e43299b633e9df71450f59
Author: Giampaolo Lauria <email address hidden>
Date: Fri Mar 15 14:55:12 2013 -0400

    Remove unnecessary checks in api.py

    Remove existing check to ensure instance was running
    when adding or removing security groups to/from an
    instance.
    Modified unit test accordingly
    Fixes bug 1107721

    Change-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b