Affinity filter checks erroneously includes deleted instances

[Hans Lindgren]

The compute API call used to gather a list of instances lacks a filter statement to exclude deleted instances.

This bug was introduced by commit 034762e8060dcf0a11cb039b9d426b0d0bb1801d and hence also affects stable/folsom.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/20568

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/20569

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20568
Committed: http://github.com/openstack/nova/commit/8bc80cab3c134d64953b4f6493cab80b5bdc1b69
Submitter: Jenkins
Branch: master

commit 8bc80cab3c134d64953b4f6493cab80b5bdc1b69
Author: Hans Lindgren <email address hidden>
Date: Sun Jan 27 21:19:16 2013 +0100

    Fix an error in affinity filters

    Fix a call to compute_api.get_all to properly exclude deleted instances.
    Add tests to prohibit this error in the future.

    After some thought, this can be further optimized to let the instance
    query do all the filtering/matching.

    Resolves bug 1107156.

    Change-Id: I6d6a6ba44d38d363489853d0407ad4cc94046656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20569
Committed: http://github.com/openstack/nova/commit/d6b9d33b231b987d9e826d25ad34c97097dc2af4
Submitter: Jenkins
Branch: stable/folsom

commit d6b9d33b231b987d9e826d25ad34c97097dc2af4
Author: Hans Lindgren <email address hidden>
Date: Sun Jan 27 21:19:16 2013 +0100

    Fix an error in affinity filters

    Fix a call to compute_api.get_all to properly exclude deleted instances.
    Add tests to prohibit this error in the future.

    After some thought, this can be further optimized to let the instance
    query do all the filtering/matching.

    Resolves bug 1107156.

    Change-Id: I6d6a6ba44d38d363489853d0407ad4cc94046656
    (cherry picked from commit 8bc80cab3c134d64953b4f6493cab80b5bdc1b69)