patch: empty files in files list, add missing "-p" to mkdir
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
svn-buildpackage (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Binary package hint: svn-buildpackage
--- svn-buildpackag
+++ svn-buildpackage 2007-04-27 13:53:18.000000000 -0400
@@ -359,6 +359,7 @@
print STDERR "DIR: $_\n" if $opt_verbose;
}
else {
+ next if /^\s*$/;
print STDERR "FILE: $_\n" if $opt_verbose;
}
@@ -419,7 +420,7 @@
else {
mkdir $bdir;
# stupid autodevtools are confused but... why?
- if(system("mkdir", map { "$bdir/$_" } sort(@dirs)) + system ("cp", "--parents", "-laf", @files, $bdir) )
+ if(system("mkdir", "-p", map { "$bdir/$_" } sort(@dirs)) + system ("cp", "--parents", "-laf", @files, $bdir) )
#open(tpipe, "| tar c --no-recursion | tar --atime-preserve -x -f- -C $bdir");
#for(@dirs) {print tpipe "$_\n"}
Without the first chunk the files list always contains "" as the first element, causing cp to always fail at line 423. Also the "-p" needs added at line 423. Since the cp succeeds, svn-buildpackage will not always use svn --export for creation of the build-area. The major implication for me in this situation is that svn:externals works when using the cp method, but svn exporting does not place the externals in the build area.
Related branches
Changed in svn-buildpackage: | |
assignee: | nobody → mok0 |
status: | New → In Progress |
Hm, adding the patch as an actual patch attachment so it doesn't get butchered by formatting :)