Heat stack-list reports wrong state on failed create

[Angus Salkeld]

I didn't register my image (restarting devstack - doh)

heat create teststack --template-file=../heat/templates/InstanceGroup.template --parameters="InstanceType=m1.large;DBUsername=wp;DBPassword=verybadpassword;KeyName=heat_key;LinuxDistribution=F16"

heat stack-list
+--------------------------------------+-----------+-----------------+----------------------+
| ID | Name | Status | Created |
+--------------------------------------+-----------+-----------------+----------------------+
| 3a0b3186-e7df-48e2-830a-4e3dad7b8e7a | teststack | CREATE_COMPLETE | 2013-01-25T01:06:19Z |
+--------------------------------------+-----------+-----------------+----------------------+

that doesn't seem right, how about create_failed?

[Angus Salkeld (asalkeld)]

Forgot to mention in the log it had the error:

 ImageNotFound: The Image (F16-x86_64-cfntools) could not be found.

[Angus Salkeld (asalkeld)]

This is because it is a nested resource (autoscaling or grouped instance).
the exception gets caught
state set to failed
then the grouped resource doesn't see the failure and sets it back to good.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/20460

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20460
Committed: http://github.com/openstack/heat/commit/6d32597f067f20797a204ff89e528336288fb8d4
Submitter: Jenkins
Branch: master

commit 6d32597f067f20797a204ff89e528336288fb8d4
Author: Angus Salkeld <email address hidden>
Date: Mon Jan 28 21:57:27 2013 +1100

    Make sure failures in groups (autoscaling & static) are raised.

    Fixes bug 1104617

    Change-Id: Iebd2b0c6a4adf8c252db31348e4dc241c0479765