--debug arg doesn't show request body

Bug #1104313 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Wishlist
Ruby Loo

Bug Description

If you specify the --debug argument, it doesn't show the body of a POST request. This is due to code in client.py, HTTPClient.http_log_req(), looking for 'body' in kwargs; it should use 'data'.

Ruby Loo (rloo)
Changed in python-keystoneclient:
assignee: nobody → Ruby Loo (rloo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20437

Changed in python-keystoneclient:
status: New → In Progress
Revision history for this message
Ruby Loo (rloo) wrote :

I would like to leave this patch as a fix to the code.

There is actually a comment in v2_0/client.py: "If debug is enabled, it may show passwords in plain text as a part of its output." :-) Redacting the password seems like a different issue (bug/feature)? I do have a code fix for that though, and am thinking that I ought to open a new bug to address that. Or I could I put that patch here, but will someone object? Who should I be trying to please? :D

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/20437
Committed: http://github.com/openstack/python-keystoneclient/commit/e0c3e30653916cd01fa4542842d86a69e0bbb077
Submitter: Jenkins
Branch: master

commit e0c3e30653916cd01fa4542842d86a69e0bbb077
Author: Ruby Loo <email address hidden>
Date: Thu Jan 24 21:42:14 2013 +0000

    If you specify the --debug argument, it doesn't show the body of a POST request. The
    body (string rep) is at 'data' in the kwargs dict. 'body' was deleted prior to this call.

    Change-Id: Ieea3d11f5246ee785e41df3bc54ac61200808354
    Fixes: bug #1104313

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.2.3
status: Fix Committed → Fix Released
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.