Correctly set UFC_LIB_DIR and UFC_PKGCONFIG_DIR

[Jonathan Underwood]

Presently UFC_LIB_DIR is hardcoded to "lib" and UFC_PKGCONFIG_DIR is hardcoded to "lib/pkgconfig" which is unhelful. The attached patch fixes things.

[Jonathan Underwood (jonathan-underwood)]

ps. this applies to 2.1.0 as well.

[Johannes Ring (johannr)]

I think perhaps a better patch is something like this.

[Garth Wells (garth-wells)]

I just pushed a change before the last comment from Johannes. Johannes: could you take a look at what I just pushed?

Jonanthan: could you test the change? Your patch failed on Ubuntu because LIB_INSTALL_DIR was not defined.

[Jonathan Underwood (jonathan-underwood)]

Garth - that's the wrong approach, hardcoding these paths is entirely the wrong fix.

[Jonathan Underwood (jonathan-underwood)]

Sorry, I meant comment #5 for Johannes, not Garth.

Am testing the patch in rev 382 now (it looks sensible though).

[Johannes Ring (johannr)]

The paths are not hardcoded with this patch. You can change them as you like in the CMake gui or when using CMake from the command line with for instance -DUFC_LIB_DIR:PATH=lib64.

This is the same approach we use in DOLFIN.

[Jonathan Underwood (jonathan-underwood)]

In fact, completely ignore comment 5, I misunderstood its intention.

[Jonathan Underwood (jonathan-underwood)]

Yes. I realized that's what you intended, Johannes, apologies for my minsunderstanding.

[Johannes Ring (johannr)]

No problem Jonathan.

Garth: should I apply the proposed patch?

[Garth Wells (garth-wells)]

On 25 January 2013 13:42, Johannes Ring <email address hidden> wrote:
> No problem Jonathan.
>
> Garth: should I apply the proposed patch?
>

Go ahead.

Garth

> ** Changed in: ufc
> Milestone: None => 2.0.7
>
> --
> You received this bug notification because you are a member of UFC Core
> Team, which is subscribed to UFC.
> https://bugs.launchpad.net/bugs/1104179
>
> Title:
> Correctly set UFC_LIB_DIR and UFC_PKGCONFIG_DIR
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ufc/+bug/1104179/+subscriptions

[Garth Wells (garth-wells)]

On 25 January 2013 14:52, Garth N. Wells <email address hidden> wrote:
> On 25 January 2013 13:42, Johannes Ring <email address hidden> wrote:
>> No problem Jonathan.
>>
>> Garth: should I apply the proposed patch?
>>
>
> Go ahead.
>

I meant to add that we should test to see if the system supplies

    LIB_INSTALL_DIR

and use it if available.

Garth

> Garth
>
>
>> ** Changed in: ufc
>> Milestone: None => 2.0.7
>>
>> --
>> You received this bug notification because you are a member of UFC Core
>> Team, which is subscribed to UFC.
>> https://bugs.launchpad.net/bugs/1104179
>>
>> Title:
>> Correctly set UFC_LIB_DIR and UFC_PKGCONFIG_DIR
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/ufc/+bug/1104179/+subscriptions