nova-dhcpbridge assumes only 2 additional arguments to add, old, del

Bug #1103783 reported by Chet Burgess
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Chet Burgess

Bug Description

The current version of the nova-dhcpbridge script will exit with an error if the add, old, or del actions are called with more then 2 additional arguments (mac, ip).

In fact dnsmasq calls the script with up to 3 additional arguments:

mac, ip, hostname

hostname is only passed if its known to dnsmasq. In a standard openstack setup it is known since we populate the dhcp host file with a name.

Chet Burgess (cfb-n)
Changed in nova:
assignee: nobody → Chet Burgess (cfb-n)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20363

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/20363
Committed: http://github.com/openstack/nova/commit/d94e693bc49d5ce717ea62f02741dccc435af3f3
Submitter: Jenkins
Branch: master

commit d94e693bc49d5ce717ea62f02741dccc435af3f3
Author: Chet Burgess <email address hidden>
Date: Thu Jan 24 02:10:18 2013 +0000

    Support optional 4 arg for nova-dhcpbridge

    dnsmasq will call the add, old, and del actions with an optional
    4 argument of hostname if the hostname is known. Since we populate
    the hostname in the DHCP host file its always passed to us.

    Add an optional 4 argument for hostname for the add, old, and del
    actions.

    Change-Id: I1a6c095324be2424d6c1d469877b254f88fba4aa
    Fixes: bug #1103783

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.