Illegal characters allowed in stack name

[Steven Hardy]

According to AWS docs for CreateStack, only alphanumeric characters should be allowed for stack names:

http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html

Although this forum post suggests hyphens are also allowed:

https://forums.aws.amazon.com/thread.jspa?threadID=102536

We don't seem to do any validation at present though, so it's possible to pass a stack name containing, for example, a comma character. There are places where we rely on comma-separated lists (e.g autoscaling but I don't think we use the fully-qualified instance resource names including the stack name) so pretty sure it's a bad idea to allow this :)

Perhaps a reasonable compromise would be to allow alphanumeric characters, hyphens, underscores and nothing else?

[Zane Bitter (zaneb)]

We disallow slashes already, if that's any help ;)

https://github.com/openstack/heat/blob/8d6aa11e707dee66c421bc2906c166fc58c150dc/heat/engine/parser.py#L62

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21596

[Steven Hardy (shardy)]

Assuming the assignee is not planning to address the review comments in the review linked above and resubmit?

pfreund - please update this bug or drop into #heat and let us know if you're still working on this, otherwise I'll assign it to myself tomorrow and resubmit such that we fix this for the rc1 milestone

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24154

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24154
Committed: http://github.com/openstack/heat/commit/2075f94b56660c97ad6e5c0829687f9d2d1803f1
Submitter: Jenkins
Branch: master

commit 2075f94b56660c97ad6e5c0829687f9d2d1803f1
Author: Steven Hardy <email address hidden>
Date: Tue Mar 12 09:50:33 2013 +0000

    heat engine : Add validation of stack names

    Add regex validation of stack names, aligns us with stack names
    allowed by AWS, with the addition of "." and "_" characters

    fixes bug 1103447

    Change-Id: I8fab0d3ad03379dfc2a18dc016e66ca8fee6cc86