iptables-restore error when table not loaded

[Ghe Rivero]

When restoring iptables within nova rules, if a iptable_[table] module is not loaded, it generates a faulty file does is rejected by iptables-restore, making nova-api not able to boot.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/20320

[Ghe Rivero (ghe.rivero)]

Error case on: http://paste.openstack.org/show/29751/

[aeva black (tenbrae)]

Also reported here:
  https://bugs.launchpad.net/nova/+bug/1103766
and here:
  https://bugs.launchpad.net/nova/+bug/1103745

[aeva black (tenbrae)]

Reported upstream bug:
  https://bugs.launchpad.net/ubuntu/+source/iptables/+bug/1104362

For easy reference, here's a log of iptables commands showing the bug:
  http://paste.openstack.org/show/29809/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20320
Committed: http://github.com/openstack/nova/commit/7d7fcf1d126d764a273b96d8ba1c940327470841
Submitter: Jenkins
Branch: master

commit 7d7fcf1d126d764a273b96d8ba1c940327470841
Author: Ghe Rivero <email address hidden>
Date: Wed Jan 23 12:53:43 2013 +0100

    iptables-restore error when table not loaded.

    When adding openstack rules, if a table module is not loaded,
    the resulted file doesn't include the section for the missing
    table, making new rules added to it, out of place and
    a no valid file for iptables-restore

    Fixes bug #1103436

    Change-Id: I34ae51a23efec57bfec37b8fa378d043fcf62d70