Async messaging framework still escapes string marked as safe

Bug #1103243 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Lin Hua Cheng

Bug Description

The asycnhronous messaging framework still escapes string marked as safe (example: mark_safe("xxx")

Example code:

from django.utils.safestring import mark_safe
from horizon import messages
...
    msg = mark_safe("Operation succeeds, to view the record click on <a href="some URL">here</a>")
    messages.success(request, msg)
...

I think the messaging framework should check for mark_safe string to be consistent with the behavior of messaging framework of django.

Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
Changed in horizon:
importance: Undecided → Low
milestone: none → grizzly-3
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21257

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/21257
Committed: http://github.com/openstack/horizon/commit/43e8ea4d4d1967f82cfdb3b2a890fd5c40e84f6e
Submitter: Jenkins
Branch: master

commit 43e8ea4d4d1967f82cfdb3b2a890fd5c40e84f6e
Author: Lin Hua Cheng <email address hidden>
Date: Tue Feb 5 14:45:47 2013 -0800

    Fix on async messaging to don't escape message string marked as safe.

    Fixes bug 1103243.

    Change-Id: Ia9541d5cc338914f5f9164e7ee1386270211f4d0

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.