Recent TaskLog refactor work on sqlalchemy/api.py has broken Instance Usage Audit Log extension

[Tiago Mello]

The recent changes made by the commit: https://review.openstack.org/#/c/19095 has broken the extension.

[Tiago Mello (timello)]

It seems the method signature has been changed and it hasn't been reflected on db/api.py. The method 'task_log_get_all' still contains 'session' parameter.

[Boris Pavlovic (boris-42)]

Would you remove session from db.api?

[Tiago Mello (timello)]

Also, the 'context' parameter is no longer been passed and it is required in the 'require_admin_context' decorator:

Example:

https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4740

It's not even being used. Same for 'task_log_get' method.

[Boris Pavlovic (boris-42)]

Thanks, would you like make patch?

[Tiago Mello (timello)]

Hey Boris. Yes, already working on it.

[Boris Pavlovic (boris-42)]

So as I understand you should:
1) call _task_log_get_query with context parameter
2) and remove session parameter from API.

One more time thanks.
Hmm.. I don't understand how tests have passed...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/20179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20179
Committed: http://github.com/openstack/nova/commit/6859f5e843a3a0cbee644661ca8b9cb1c88894a0
Submitter: Jenkins
Branch: master

commit 6859f5e843a3a0cbee644661ca8b9cb1c88894a0
Author: Tiago Mello <email address hidden>
Date: Mon Jan 21 20:01:40 2013 -0200

    Fixes task_log_get and task_log_get_all signatures

    Fixes signatures for the above methods in nova/db/api.py
    based on the recent TaskLog refactor on sqlalchemy/api.py.
    Also adds unit tests for TaskLog.

    Fixes Bug 1102652.

    Change-Id: Id7ce74b8941d9eb6a50dfbfaa62e0fe05dd467c2

[Boris Pavlovic (boris-42)]

Good job.