libvirt: 'instane' typo while adding configdrive

Bug #1101352 reported by Michael Fork
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Mathew Odden

Bug Description

There was an erroneous reference to 'instane' instead of 'instance' in the code block that builds a libvirt block device for configdrive.

Also, the configdrive block of get_guest_storage_config in nova/virt/libvirt/driver.py has no unit test coverage.

Mathew Odden (locke105)
Changed in nova:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20058

Changed in nova:
assignee: nobody → Mathew Odden (locke105)
status: Confirmed → In Progress
Mathew Odden (locke105)
description: updated
Mathew Odden (locke105)
summary: - Missing tests for libvirt configdrive impl
+ libvirt: 'instane' typo while adding configdrive
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/20044
Committed: http://github.com/openstack/nova/commit/9860891a09eb58adadbd519644906e1c6215bf3b
Submitter: Jenkins
Branch: master

commit 9860891a09eb58adadbd519644906e1c6215bf3b
Author: Michael J Fork <email address hidden>
Date: Fri Jan 18 19:03:45 2013 +0000

    libvirt: Fix typo in configdrive implementation

    libvirt configdrive implementation
    references 'instane' instead of 'instance'.
    Also, add a test for adding configdrive block device
    that would catch such an error

    fixes bug 1101352

    Change-Id: I36cba4487ad9d78d4e0366c8c2550603ba155c47

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.