memory leak in http_translator

Bug #1101254 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Low
Unassigned

Bug Description

osrfHttpTranslatorParseRequest() deserializes a request into an array of osrfMessage, but doesn't free the members of the resulting list before it exists.

OpenSRF 2.1.2
OpenSRF master

Tags: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available at the tip of the user/gmcharlt/lp1101254_translator_memory_leak branch in working/OpenSRF

Changed in opensrf:
importance: Undecided → Low
milestone: none → 2.0.2
milestone: 2.0.2 → 2.1.3
tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote : Re: [Bug 1101254] Re: memory leak in http_translator

Code looks good. Testing on my dev system. I'm going to let it run for a
while. -b

On Fri, Jan 18, 2013 at 10:44 AM, Galen Charlton <email address hidden> wrote:

> A patch is available at the tip of the
> user/gmcharlt/lp1101254_translator_memory_leak branch in working/OpenSRF
>
> --
> You received this bug notification because you are subscribed to
> OpenSRF.
> Matching subscriptions: OpenSRF Bugs
> https://bugs.launchpad.net/bugs/1101254
>
> Title:
> memory leak in http_translator
>
> Status in OpenSRF - Open Scalable Request Framework:
> New
>
> Bug description:
> osrfHttpTranslatorParseRequest() deserializes a request into an array
> of osrfMessage, but doesn't free the members of the resulting list
> before it exists.
>
> OpenSRF 2.1.2
> OpenSRF master
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/opensrf/+bug/1101254/+subscriptions
>

--
Bill Erickson
| Senior Software Developer
| phone: 877-OPEN-ILS (673-6457)
| email: <email address hidden>
| web: http://esilibrary.com
| Equinox Software, Inc. / Your Library's Guide to Open Source

Revision history for this message
Galen Charlton (gmc) wrote :

It's been a while -- looking good on your dev system?

Revision history for this message
Bill Erickson (berick) wrote :

Looking good. Applied the same logic to the websockets translator with success as well. Pushed to master. Thanks, Galen!

Changed in opensrf:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.