Unknown property not detected

Bug #1101098 reported by Pierre Freund
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Angus Salkeld

Bug Description

Unknown property of a ressource is not detected.

If I add this property in an instance ressource :

        "Volumes" : [{
          "VolumeId" : { "Ref" : "DataVolume" },
          "Device" : "/dev/vdc"
        }],

"Volumes" is detected as an unsupported : "Malformed Query Response WikiDatabase: Volumes Property not implemented yet"
But if I make a typo error, like "Volmes" or a random string, the stack is created, ignoring the property.

To prevent typo error, unknown property should be detected and make stack failed/rollback.

description: updated
Revision history for this message
Zane Bitter (zaneb) wrote :

A possible downside of enforcing this would be that it could limit upwards compatibility. We definitely need at least a warning though.

Zane Bitter (zaneb)
Changed in heat:
importance: Undecided → Medium
status: New → Triaged
Angus Salkeld (asalkeld)
Changed in heat:
assignee: nobody → Angus Salkeld (asalkeld)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23157

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/23492

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/23492
Committed: http://github.com/openstack/heat/commit/e9cba1bb0a423fe117e4c636a04c9134512c8fc5
Submitter: Jenkins
Branch: master

commit e9cba1bb0a423fe117e4c636a04c9134512c8fc5
Author: Angus Salkeld <email address hidden>
Date: Tue Mar 5 11:49:12 2013 +1100

    vpc_test: move DependsOn to the correct template section

    found when fixing bug #1101098
    Signed-off-by: Angus Salkeld <email address hidden>

    Change-Id: I7591111bcdf768119d265d0a9c901a0e189604d3

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/23157
Committed: http://github.com/openstack/heat/commit/9a682de2f1735c276903eb39c980abfe033cf9c0
Submitter: Jenkins
Branch: master

commit 9a682de2f1735c276903eb39c980abfe033cf9c0
Author: Angus Salkeld <email address hidden>
Date: Tue Mar 5 22:17:12 2013 +1100

    Fail validation when an unknown property is supplied in a template.

    bug #1101098
    Change-Id: I9430ad859e9a93d6c0d2a417877e02c151e98a05

Thierry Carrez (ttx)
Changed in heat:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.