WaitCondition should validate Handle URL

Bug #1100754 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steven Hardy
Grizzly
Fix Released
Medium
Steven Hardy

Bug Description

Currently WaitCondition does not validate the handle URL passed (other than to ensure it parses as a valid ARN)

We should add a check to ensure the Handle ARN maps to the same stack as the WaitCondition resource (because we can't lookup the resource if it's owned by a different stack), and that the resource specified in the ARN is a WaitConditionHandle

Steven Hardy (shardy)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
milestone: none → grizzly-3
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21010

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/21010
Committed: http://github.com/openstack/heat/commit/c751abc05debe98dff4efde44bb1c9cb43230562
Submitter: Jenkins
Branch: master

commit c751abc05debe98dff4efde44bb1c9cb43230562
Author: Steven Hardy <email address hidden>
Date: Fri Feb 1 13:01:18 2013 +0000

    heat engine : WaitCondition add Handle property validation

    Add validation to the Handle property for WaitCondition, so
    we check that the identifier in the provided URL maps to
    a WaitConditionHandle resource in the same stack as the
    WaitCondition

    fixes bug 1100754

    Change-Id: I44c8f52435016fad5a35183472d2b0df26c1915d

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.