Booting an image without a kernel/initrd on baremetal fails without telling user why

[Clint Byrum]

Steps to reproduce:

1. setup baremetal hypervisor
2. upload image without specifying kernel/initrd
3. boot server with said image
4. Wait till nova list/show shows the server as "ACTIVE"
5. observe system failing to boot with "invalid kernel" message after deploy kernel boots properly and lays image down.
6. on tftp server note that "kernel" is written as a json file that looks like a response from keystone about images.

What would I expect:

The node should immediately go into ERROR state, or preferably would fail on asking to boot with a baremetal flavor and no kernel.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/19954

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/19954
Committed: http://github.com/openstack/nova/commit/2af896ceccc6fa947bbdb8b06442439db1c6dc1f
Submitter: Jenkins
Branch: master

commit 2af896ceccc6fa947bbdb8b06442439db1c6dc1f
Author: Devananda van der Veen <email address hidden>
Date: Thu Jan 17 09:09:32 2013 -0800

    PXE driver should not accept empty kernel UUID.

    Baremetal PXE driver was aborting only if the kernel and ramdisk
    specified in image metadata were None, but not if they were another
    non-true value, such as "". Now, exception is raised if they are any
    non-true value.

    Fix bug 1100589.

    Change-Id: I9783a14cc242e1b9db04d797c61d54b06d52c680