cfn-init data/logs world readable

[Steven Hardy]

Currently the /var/log/heat-provision.log file, and related data files under /var/lib/cloud/data are world readable.

This means credentials/passwords provided to the instance via user-data are not secure, we should make these readable only by root.

[Steve Baker (steve-stevebaker)]

I hope you don't mind if I take this, I'm poking around here at the moment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/21149
Committed: http://github.com/openstack/heat/commit/c598d0d3e81b0dbd46fe9239a49ffda16ced5378
Submitter: Jenkins
Branch: master

commit c598d0d3e81b0dbd46fe9239a49ffda16ced5378
Author: Steve Baker <email address hidden>
Date: Tue Feb 5 10:10:11 2013 +1300

    Refactor loguserdata.py so it can be tested.

    - Use distutils.version.LooseVersion for cloud-init version check
    - Fix bug 1100287 by setting the following modes:
      - 0600 /var/log/heat-provision.log
      - 0700 /var/lib/heat
      - 0700 /var/lib/cloud/data/cfn-userdata (was 0111!)
    - Full test coverage except for where __name__ == '__main__'
    - File size has gone from 1218 bytes to 1636. If necessary we could reduce size in the future by using short names

    This works for me when launching a template. At least if there are any regressions they can have a test written for the fix.
    Change-Id: I04e773a743ec210e90394e50d2bb70c70664e80e