Launcher starts with default size then jumps to configured one on login
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) |
Bug Description
STR:
1. Set launcher size to 32px in System Settings / Appearance
2. Log out
3. Log in
Expected results:
When launcher appears, it is 32px wide.
Actual results:
Launcher appears at full size (64px?) then switches to the configured width after a little while.
ProblemType: Bug
DistroRelease: Ubuntu 13.04
Package: unity 6.12.0daily13.
ProcVersionSign
Uname: Linux 3.8.0-0-generic x86_64
ApportVersion: 2.8-0ubuntu1
Architecture: amd64
CompizPlugins: No value set for `/apps/
CrashDB: unity
Date: Tue Jan 15 14:07:32 2013
InstallationDate: Installed on 2013-01-04 (11 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Alpha amd64 (20130104)
MarkForUpload: True
SourcePackage: unity
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Unity Team: Pending requested
-
Diff: 11 lines (+1/-0)1 file modifiedplugins/unityshell/src/unityshell.cpp (+1/-0)
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 147 lines (+10/-16)6 files modifiedlauncher/LauncherController.cpp (+4/-10)
launcher/LauncherController.h (+0/-2)
launcher/LauncherControllerPrivate.h (+0/-1)
launcher/LauncherOptions.cpp (+4/-1)
launcher/LauncherOptions.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+1/-2)
Changed in unity: | |
milestone: | none → 7.0.0 |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
importance: | Undecided → Low |
Changed in unity: | |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
Changed in unity: | |
assignee: | Brandon Schaefer (brandontschaefer) → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
assignee: | Brandon Schaefer (brandontschaefer) → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
status: | Fix Committed → New |
Thank you for reporting this bug. I can confirm this here.
The cause is launcher is created and gets drawn before the icon size is set (though the CCSM options). The fix would most likely be in unity/plugin/ unityshell/ src/unityshell. cpp (its a huge file). Looks for launcher_ controller_ (line ~3216) and where it gets created (with an std::make_shared). You will most likely have to change the launcher_options_ icon size right away vs waiting for it to get set. Right after this we should most likely try and set the icon size from compiz. We currently are setting it here: ns::IconSize: (about line ~3039).
case UnityshellOptio
Hopefully this gives enough info to help get started :).