nec-agent dies with no such option: DATABASE

Bug #1099162 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Akihiro Motoki

Bug Description

In commit be3b5dcd6ddaae809ef1b1e18bf47703deaf74a8, database configuration was moved to common module.
quantum/plugins/nec/common/config.py still has "DATABASE = cfg.CONF.DATABASE" and
this module is loaded from nec plugin agent, but in the agent cfg.CONF.DATABASE is not loaded.
This results in the following error.

It can be fixed by just removing "DATABASE = cfg.CONF.DATABASE" since there is no database access on the agent side
and on the server side the common logic now handles the database access.

Traceback (most recent call last):
  File "/opt/stack/quantum/bin/quantum-nec-agent", line 22, in <module>
    from quantum.plugins.nec.agent.nec_quantum_agent import main
  File "/opt/stack/quantum/quantum/plugins/nec/agent/nec_quantum_agent.py", line 34, in <module>
    from quantum.plugins.nec.common import config
  File "/opt/stack/quantum/quantum/plugins/nec/common/config.py", line 49, in <module>
    DATABASE = cfg.CONF.DATABASE
  File "/opt/stack/quantum/quantum/openstack/common/cfg.py", line 1150, in __getattr__
    return self._get(name)
  File "/opt/stack/quantum/quantum/openstack/common/cfg.py", line 1454, in _get
    value = self._substitute(self._do_get(name, group))
  File "/opt/stack/quantum/quantum/openstack/common/cfg.py", line 1470, in _do_get
    info = self._get_opt_info(name, group)
  File "/opt/stack/quantum/quantum/openstack/common/cfg.py", line 1570, in _get_opt_info
    raise NoSuchOptError(opt_name, group)
quantum.openstack.common.cfg.NoSuchOptError: no such option: DATABASE

Akihiro Motoki (amotoki)
Changed in quantum:
assignee: nobody → Akihiro Motoki (amotoki)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19579

Changed in quantum:
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in quantum:
milestone: none → grizzly-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/19579
Committed: http://github.com/openstack/quantum/commit/6cd4789008af6f148814b948980262e4d8fab0ed
Submitter: Jenkins
Branch: master

commit 6cd4789008af6f148814b948980262e4d8fab0ed
Author: Akihiro MOTOKI <email address hidden>
Date: Mon Jan 14 02:57:33 2013 +0900

    Remove accessing cfg.CONF.DATABASE in nec-agent

    Fixes bug 1099162

    The database configuration was moved to the common DB module.
    There no longer needs to access database configuration in the
    plugin specific code.

    Change-Id: I4b80ea1e84ffa06d0fffa7f8ccdee08a5b77e239

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.