xenapi get_all_bw_counters accesses instance as object

Bug #1098382 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Behrens

Bug Description

314 imap = dict([(inst.name, inst.uuid) for inst in instances])

Needs to change to access as dict.

2013-01-10 16:32:22.384 19286 TRACE nova.manager File "/home/cbehrens/git/nova/openstack.git/nova/virt/xenapi/driver.py", line 314, in get_all_bw_counters
2013-01-10 16:32:22.384 19286 TRACE nova.manager imap = dict([(inst.name, inst.uuid) for inst in instances])
2013-01-10 16:32:22.384 19286 TRACE nova.manager AttributeError: 'dict' object has no attribute 'name'

Chris Behrens (cbehrens)
Changed in nova:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Chris Behrens (cbehrens)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19437

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19437
Committed: http://github.com/openstack/nova/commit/97f0ec7039611e4c9a7c543ea4631d7182a5ec99
Submitter: Jenkins
Branch: master

commit 97f0ec7039611e4c9a7c543ea4631d7182a5ec99
Author: Chris Behrens <email address hidden>
Date: Fri Jan 11 00:40:57 2013 +0000

    Access instance as dict, not object in xenapi

    get_all_bw_counters() in XenAPI was accessing instances as objects
    instead of dicts.

    Fixes bug 1098382

    Change-Id: I9a783c0f403b60d392dc26a25b93683e7c145600

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.