OpenStack Heat

WaitCondition "Count" property is ignored

Bug #1097813 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steven Hardy
OpenStack Heat 2013.1 "grizzly"
Grizzly
Fix Released
Medium
Steven Hardy
OpenStack Heat grizzly-3 "g3"

Bug Description

We currently accept the "Count" property for WaitCondition resources, but don't do anything with it, so regardless of what the Count property is, the WaitCondition will always go to CREATE_COMPLETE after one signal from the WaitConditionHandle

Steven Hardy (shardy)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Steven Hardy (shardy)
milestone: none → grizzly-3
Steven Hardy (shardy)
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19639

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/19641

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/19639
Committed: http://github.com/openstack/heat/commit/25f20dc848bbf9b1508039a48bebddcf62696512
Submitter: Jenkins
Branch: master

commit 25f20dc848bbf9b1508039a48bebddcf62696512
Author: Steven Hardy <email address hidden>
Date: Fri Jan 11 11:08:34 2013 +0000

    heat engine : implement metadata_update per-resource

    Abstract updates to resource metadata so they are implemented per-resource,
    with a generic implementation which is a no-op, since currently the only
    resource which needs metadata update via the RPC API is WaitConditionHandle.
    This allows resource-specific metadata validation and update logic to be more
    easily added.

    ref bug 1097813

    Change-Id: I094e74b6cd8cb2436f05beed9629fc3c3a34e622
    Signed-off-by: Steven Hardy <email address hidden>

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/19641
Committed: http://github.com/openstack/heat/commit/21c960aca3d44ba598500aaa7b338c746adff5a9
Submitter: Jenkins
Branch: master

commit 21c960aca3d44ba598500aaa7b338c746adff5a9
Author: Steven Hardy <email address hidden>
Date: Mon Jan 14 16:59:03 2013 +0000

    heat engine : Implement Count property for WaitCondition

    The Count property of WaitCondition is currently ignored, so
    regardless of the number specified the WaitCondition resource will
    always go to CREATE_COMPLETE on the first WaitConditionHandle signal.
    This patch fixes this so the Count property is handled correctly.

    fixes bug 1097813

    Change-Id: I71348c553702c0282a8826488c953ac3c2c76e38
    Signed-off-by: Steven Hardy <email address hidden>

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.