V2: Endpoint creation with missing URL returns 500

[Unmesh Gurjar]

Branch: master

Steps to repro:
1. Create an endpoint without specifying either or all of adminurl, internalurl or publicurl as follows:
$ keystone endpoint-create --service-id 6920e3f02bfd4bc89e06539818c83cdc

2. Observe the response.

Expected Behavior:
API should return a 400 Bad Request with appropriate message.

Actual Response:
API returns a 500 Internal Server Error with the following response body:
Unable to communicate with identity service: {"error": {"message": "An unexpected error prevented the server from fulfilling your request. (OperationalError) (1048, \"Column 'url' cannot be null\") 'INSERT INTO endpoint (id, interface, region, service_id, url, extra) VALUES (%s, %s, %s, %s, %s, %s)' ('8622653655e545e8b86876ce7badafe4', 'admin', 'regionOne', '6920e3f02bfd4bc89e06539818c83cdc', None, '{\"legacy_endpoint_id\": \"f59f7a01857147a39c4caf5a6a7d0ef0\"}')", "code": 500, "title": "Internal Server Error"}}. (HTTP 500)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/19431

[Brant Knudson (blk-u)]

Shouldn't the expected response in this case be that the keystone command says that that the --adminurl, --internalurl, and --publicurl arguments are required? It shouldn't even send the request to the keystone server.

The server is also not working correctly, but I think the keystone command should validate its arguments too so that you can print out a more understandable error message.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/19431
Committed: http://github.com/openstack/keystone/commit/3a38ecfc8868c95ad3df43de22b29f08f2c9d4cf
Submitter: Jenkins
Branch: master

commit 3a38ecfc8868c95ad3df43de22b29f08f2c9d4cf
Author: Tushar Patil <email address hidden>
Date: Thu Jan 10 00:46:23 2013 -0800

    Validated URLs in v2 endpoint creation API

    Fixed the 500 response when endpoint is created without specifying
    either adminurl, publicurl or internalurl empty.
    Added unit test coverage for v2 endpoint create API.

    Fixes LP: #1097747

    Change-Id: I1875859bd7e197e985a5b5395c8caefff3c83b11