quantum metadata proxy does not forward IP properly

Bug #1097524 reported by Mark McClain
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Mark McClain
neutron
Fix Released
Undecided
Mark McClain

Bug Description

The Quantum metadata proxy does not include the forwarded IP address in the header from Quantum to Nova. Additionally, Nova defaults to the requesting server IP which is the proxy IP and not the guest instance local IP.

Thanks to Marton Kiss for finding this bug.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19267

Changed in nova:
assignee: nobody → Mark McClain (markmcclain)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19268

Changed in quantum:
assignee: nobody → Mark McClain (markmcclain)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/19268
Committed: http://github.com/openstack/quantum/commit/3aecb35d6859f17553b0241e71c137bc933aca37
Submitter: Jenkins
Branch: master

commit 3aecb35d6859f17553b0241e71c137bc933aca37
Author: Mark McClain <email address hidden>
Date: Tue Jan 8 19:18:58 2013 -0500

    Pass X-Forwarded-For header to Nova

    fixes bug 1097524

    Add X-Forwarded-For header to the proxied Nova metadata request. Nova
    needs this value to properly answer /latest/meta-data/local-ipv4
    requests.

    Change-Id: Icaec38b2ca7e06b50960deb7ab24ff1944a81f45

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19267
Committed: http://github.com/openstack/nova/commit/2fc0097c5beaab9c33b19adc3e1d0051d5a62781
Submitter: Jenkins
Branch: master

commit 2fc0097c5beaab9c33b19adc3e1d0051d5a62781
Author: Mark McClain <email address hidden>
Date: Tue Jan 8 18:59:20 2013 -0500

    Quantum metadata handler now uses X-Forwarded-For

    fixes bug 1097524

    The guest IP address was not properly forwarded from the Quantum
    metadata proxy. This patch adds support in Nova for reading this
    X-Forwarded-For header. Previously, the internal proxy IP was
    mistakenly used exposing internal infrastructure details.

    Change-Id: I6d7d21e2aea4ca5debf1ca4ba6802012537f78a5

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-2 → 2013.1
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.