Drag and dropping multiple items is not possible in column view with left click

[Thomas Dalichow]

Hey guys,

now I finally got time to report some bugs which are really annoying to me. First and foremost this is not being able to drag and drop multiple files in "Files".

Selecting multiple files is possible by using [ctrl] but dragging / dropping does not work. Only the file I click on is dragged / dropped.

Is this the intended behaviour of files? That would really be a major drawback.

Regards,
Thomas

[Thomas Dalichow (twizzydizzy)]

Alright... I just tried to narrow the impact of this bug.

Seems like dragging/dropping does work in grid and list view of "Files", but not in column view.

Regards,
Thomas

[Julián Unrrein (junrrein)]

I can confirm this bug, but only when dragging the selected files/folders using the primary mouse button.
When using the secondary one (i.e. right-click and drag) drag and dropping works fine.

[Thomas Dalichow (twizzydizzy)]

@junrrein True. But I guess it should work "as expected", though :)

[Ian Santopietro (isantop)]

As a note, this is happening in grid view as well.

[Jeremy Wootten (jeremywootten)]

Yes, it will need a separate branch to fix it in grid (icon) view. I'll
try and have a look at it when I get back form holiday.

On 19 June 2014 18:55, Ian Santopietro <email address hidden> wrote:

> As a note, this is happening in grid view as well.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1096620
>
> Title:
> Drag and dropping multiple items is not possible in column view with
> left click
>
> Status in Pantheon Files:
> In Progress
>
> Bug description:
> Hey guys,
>
> now I finally got time to report some bugs which are really annoying
> to me. First and foremost this is not being able to drag and drop
> multiple files in "Files".
>
> Selecting multiple files is possible by using [ctrl] but dragging /
> dropping does not work. Only the file I click on is dragged / dropped.
>
> Is this the intended behaviour of files? That would really be a major
> drawback.
>
> Regards,
> Thomas
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pantheon-files/+bug/1096620/+subscriptions
>

[Thomas Dalichow (twizzydizzy)]

Hey guys,

since I recently got the mail saying "milestone: freya-beta2 → none" I was wondering wether I can be of any assistance in terms of testing or the like. I just tried it again using a fully upgraded version of freya and it's still there.

Looking forward to freya :)

Cheers
Thomas

[Jeremy Wootten (jeremywootten)]

Hello Thomas

You might like to help testing
 lp:~jeremywootten/pantheon-files/all-views-vala which provides a fix for
this bug (amongst several others).

Note that in this branch, dragging and activation with the primary (left)
button only happens on the icons, but works with multiple selections.

Other areas have different actions as indicated by the shape of the
cursor. Clicking on the text of the name starts renaming, clicking on a
blank area selects and allows rubberbanding. Clicking without dragging
with the secondary (right) on any unselected blank space shows the root
folder context menu; right clicking on a selected item shows the item
menu. Right clicking and dragging on an icon or any selected area
initiates a drag-ask action.

Thanks for your offer of help!.

On 8 October 2014 23:56, Thomas Dalichow <email address hidden> wrote:

> Hey guys,
>
> since I recently got the mail saying "milestone: freya-beta2 →
> none" I was wondering wether I can be of any assistance in terms of
> testing or the like. I just tried it again using a fully upgraded
> version of freya and it's still there.
>
> Looking forward to freya :)
>
> Cheers
> Thomas
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1096620
>
> Title:
> Drag and dropping multiple items is not possible in column view with
> left click
>
> Status in Pantheon Files:
> In Progress
>
> Bug description:
> Hey guys,
>
> now I finally got time to report some bugs which are really annoying
> to me. First and foremost this is not being able to drag and drop
> multiple files in "Files".
>
> Selecting multiple files is possible by using [ctrl] but dragging /
> dropping does not work. Only the file I click on is dragged / dropped.
>
> Is this the intended behaviour of files? That would really be a major
> drawback.
>
> Regards,
> Thomas
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pantheon-files/+bug/1096620/+subscriptions
>

[Thomas Dalichow (twizzydizzy)]

Hey Jeremy,

I just built all-views-vala (revno: 1589) and followed the build instructions in ./INSTALL file.

Starting pantheon-files now throws

  pantheon-files: symbol lookup error: pantheon-files: undefined symbol: gof_files_launch_with

Am I supposed to also build pantheon files from BZR? Sorry for those seemingly dumb questions ;)

Cheers,
Thomas

[Cody Garver (codygarver)]

It was removed from the milestone because the branch that fixed it is/was
an ongoing work in progress and it's not high enough priority bug to block
the release of a beta and wanted a clear milestone. Fortunately, it looks
like the branch might make it in before the start of Freya beta2.

You can help test the branch with these instructions:

bzr branch lp:pantheon-files

cd pantheon-files

bzr merge lp:~jeremywootten/pantheon-
files/all-views-vala

mkdir build

cd build

cmake .. -DCMAKE_INSTALL_PREFIX=/usr

sudo make -j install

On Thu, Oct 9, 2014 at 5:41 PM, Thomas Dalichow <
<email address hidden>> wrote:

> Hey Jeremy,
>
> I just built all-views-vala (revno: 1589) and followed the build
> instructions in ./INSTALL file.
>
> Starting pantheon-files now throws
>
> pantheon-files: symbol lookup error: pantheon-files: undefined symbol:
> gof_files_launch_with
>
> Am I supposed to also build pantheon files from BZR? Sorry for those
> seemingly dumb questions ;)
>
> Cheers,
> Thomas
>
> --
> You received this bug notification because you are subscribed to Files.
> https://bugs.launchpad.net/bugs/1096620
>
> Title:
> Drag and dropping multiple items is not possible in column view with
> left click
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pantheon-files/+bug/1096620/+subscriptions
>

--
Cody Garver

[Thomas Dalichow (twizzydizzy)]

Hi Jeremy, Hi Cody,

now we're talking. Merge & build went fine and I could test the dragging and dropping.

It now works as expected (from a usability point of view) though no dropping of multiple selected items to the sidebar (e.g. Trash) was possible but I assume this is no part of this branch.

Renaming with a single click is - by the way - a nice optimization of file handling. Kudos!

There's another "issue" which just realized (we may take it to another bug, if you don't want to "pollute" the bug at hand):

The width of a column seems to be determined by the width of the longest folder name. With short folder names, though, I feel a little uncomfortable with the small width, to narrow to let the eye "breathe". Maybe adding some kind of minimum width for columns or at least some space [1] between the end of the folder name and actual border of the column would do the trick. I have't really gotten around to reading the usability guidelines but I thought a feel of lightness was some kind of goal :)

[1] probably with a gradual ratio of "the shorter the folder name the more whitespace to the right"

Cheers
Thomas

[Jeremy Wootten (jeremywootten)]

Thanks for the review Thomas!

In column auto-sizing there is a minimum column width (set to half the preferred width set in dconf org/pantheon/files/columnview/preferred-column-width), but I think you are right that it is too small - I will set it to be the preferred width. The column can be manually resized below this minimum width anyway.

Dragging and dropping onto the sidebar isnt part of this branch but its a good idea.

[PerfectCarl (name-is-carl)]

Fixed in files/all-views-vala
tested in 3 modes : folder, item and columns