lockutils test_synchronized_externally is racy and regularly fails

Bug #1095957 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
High
Mark McLoughlin
Grizzly
Fix Released
High
Mark McLoughlin

Bug Description

In Jenkins, we're very regularly seeing this test failure:

  FAIL: We can lock across multiple processes
  ----------------------------------------------------------------------
  Traceback (most recent call last):
     File "/home/jenkins/workspace/gate-oslo-incubator-python27/tests/unit/test_lockutils.py", line 164, in test_synchronized_externally
       f(rpipe2, wpipe1)
     File "/home/jenkins/workspace/gate-oslo-incubator-python27/openstack/common/lockutils.py", line 221, in inner
       retval = f(*args, **kwargs)
     File "/home/jenkins/workspace/gate-oslo-incubator-python27/tests/unit/test_lockutils.py", line 147, in f
       self.assertEquals(len(rfds), 0, "The other process, which was "
    AssertionError: The other process, which was supposed to be locked, wrote on its end of the pipe
       '1 != 0' = '%s != %s' % (safe_repr(1), safe_repr(0))
       'The other process, which was supposed to be locked, wrote on its end of the pipe' = self._formatMessage('The other process, which was supposed to be locked, wrote on its end of the pipe', '1 != 0')
  >> raise self.failureException('The other process, which was supposed to be locked, wrote on its end of the pipe')

It has gotten to the stage that we need to turn off this test, but this bug report will keep track of the fact that we still need to fix it.

Changed in oslo:
assignee: nobody → Mark McLoughlin (markmc)
status: Triaged → In Progress
Revision history for this message
Mark McLoughlin (markmc) wrote :

Here's an effort we made previously to fix it: https://review.openstack.org/14556

Practically speaking, this bug is probably a duplicate of bug #1068316

Thierry Carrez (ttx)
summary: - lockutils test_synchronized_externally regularly fails
+ lockutils test_synchronized_externally is racy and regularly fails
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/18947
Committed: http://github.com/openstack/oslo-incubator/commit/bc50f1ea933ef0488336237f563be24ea509a5f2
Submitter: Jenkins
Branch: master

commit bc50f1ea933ef0488336237f563be24ea509a5f2
Author: Mark McLoughlin <email address hidden>
Date: Fri Jan 4 06:56:42 2013 +0000

    Disable lockutils test_synchronized_externally

    We're seeing this test fail very regularly in Jenkins and it's become
    a serious distraction for everyone.

    Disable the test temporarily and use a bug #1095957 to track that the
    test itself needs fixing.

    Change-Id: I0645d8f5f740d40f83d82e5ef7a048f33a44ac2b

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.