Untranslatable strings in Register Patron -page

[Pasi Kallinen]

The user setting labels are untranslatable in the Register Patron -page. Attached screenshot shows the problem.

Looks like the labels don't have oils_i18n_gettext() in the insert statements in 950.data.seed-values.sql

[Pasi Kallinen (paxed)]

I originally found this out in https://bugs.launchpad.net/evergreen/+bug/1078596/comments/4

[Dan Scott (denials)]

Curious, 'git blame' says commit fb103148 wrapped those user settings in oils_i18n_gettext(). The actual problem is that the fieldmapper definitions haven't included the oils_persist:i18n attribute for the label and description fields.

See http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1095252_i18n_cust for what should fix this problem.

[Pasi Kallinen (paxed)]

Dan, I tried your fix, but I can't get the "Default Hold Pickup Location", "Hold is behind Circ Desk" and "Hold Notification Format" labels to show up in any of the po files.

Note that the "Default Phone Number" does have the oils_i18n_gettext() wrapper, but some other config.usr_setting_type inserts don't, such as "Default Hold Pickup Location".

The "Default Phone Number" shows up in tpac.*.po, but not in the fm_IDL.* - and the translation doesn't show up in the patron registration page.

[Pasi Kallinen (paxed)]

This branch marks the config.usr_setting_type inserts with oils_i18n_gettext that are missing it: user/paxed/wrap-db-seed-sql-i18n-gettext

[Ben Shum (bshum)]

If I'm reading the above correctly, I guess we should pick both Dan's commit to add i18n attributes in the fieldmapper along with Pasi's commit to allow translation of some more user setting types.

Picking them both into the same working branch here in review: user/bshum/lp1095252-i18n-usr-setting

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1095252-i18n-usr-setting

The part I'm unclear about is how to create the upgrade SQL to handle fixing this in existing installations (if we do?)

[Remington Steed (rjs7)]

Ben, it is my understanding that i18n changes do not require an upgrade script, because the upgrade process doesn't yet participate in the translation-building process. If this is true, then perhaps we should open a bug to address this. But regarding this bug, your branch should be enough.

[Remington Steed (rjs7)]

I tested Ben's branch by:

-- running the SQL INSERT statements (they worked correctly)
-- applying the change to the IDL, restarting all Evergreen services, restarting apache, and testing the staff client User Setting Types interface (it worked fine)

So I have signed off on both commits, rebased to master and pushed it here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1095252-i18n-usr-setting

working/user/rsteed/lp1095252-i18n-usr-setting

[Ben Shum (bshum)]

Sounds logical and yep, not including i18n stuff into upgrade SQL for now.

Thanks for testing Remington, and Dan and Pasi for the patches.

Pushed to master!