uploading a file - "Loading" message remains

[Jiri Baum (Catalyst)]

When uploading a file, the "Loading ..." message at the top left of the screen remains.

Steps to reproduce:
1) Log in as Admin.
2) Go to Administration -> Site files.
3) Upload a file by clicking on the "Browse" button and selecting a file.
4) Observe that a "Loading ..." message appears in the top left-hand corner of the page and does not disappear.

There is a JavaScript error in the browser console, which may or may not be related to the problem:
  TypeError: elem is null
  if(typeof (elem.w)=="number"||typeof (elem.h)=="number"){
  js/MochiKit/Packed.js (line 3694)

Versions:
* master bf58c38
* 1.6_STABLE 4892034

[Jiri Baum (Catalyst) (jiri-catalyst)]

The same problem appears when uploading files to the Content -> Files area, whether as an admin, as a masqueraded normal user or as a real normal user.

[Ruslan Kabalin (rkabalin)]

The problem caused by accessing $('artefactchooser-body') on the page that does not have this block, as result of JS error, formStopProcessing is not being called, thus 'Loading' remains on the page.

[Ruslan Kabalin (rkabalin)]

Fixes:
Master: https://reviews.mahara.org/#/c/2400/
1.7: https://reviews.mahara.org/#/c/2401/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2400
Committed: http://gitorious.org/mahara/mahara/commit/cb2c02db5f63eac9dfa3ce15e109832a965f8f82
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit cb2c02db5f63eac9dfa3ce15e109832a965f8f82
Author: Ruslan Kabalin <email address hidden>
Date: Mon Aug 12 16:36:02 2013 +0100

Fix "Loading" message issue. (bug #1095208)

Change-Id: I2e4c57709653a87950ca1a76505b99e4ca400085
Signed-off-by: Ruslan Kabalin <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2401
Committed: http://gitorious.org/mahara/mahara/commit/83b2d1db1ecb9adc95622ffd4ecfc5cc12740880
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.7_STABLE

commit 83b2d1db1ecb9adc95622ffd4ecfc5cc12740880
Author: Ruslan Kabalin <email address hidden>
Date: Mon Aug 12 16:36:02 2013 +0100

Fix "Loading" message issue. (bug #1095208)

Change-Id: I2e4c57709653a87950ca1a76505b99e4ca400085
Signed-off-by: Ruslan Kabalin <email address hidden>