Nova API source has some buggy and inconsistent exception handling

Bug #1094035 reported by Rohit Karajgi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Justin Shepherd

Bug Description

Many parts of servers API (https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py)
call webob exceptions inconsistently.
All the code should raise exc.<Exception> instead of webob.exc.<Exception> at many places.

Also, the exception messages in lines 833 - 847 won't get printed. They should use explanation=msg kwarg.

Tags: ntt
Changed in nova:
assignee: nobody → Justin Shepherd (jshepher)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19685

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19685
Committed: http://github.com/openstack/nova/commit/12e38d98d5ae5a5ffd80e969172fb468af044211
Submitter: Jenkins
Branch: master

commit 12e38d98d5ae5a5ffd80e969172fb468af044211
Author: Justin Shepherd <email address hidden>
Date: Tue Jan 15 04:05:11 2013 +0000

    Cleaning up exception handling

    bug 1094035

    Change-Id: I91e134a3632e6b3314fe90d25e2df780aaba54d1

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.