Decide if "Load to Preview Deck" in context menu should respect track load behaviour

[jus]

Tested with latest lp:mixxx/1.11 MacOSX

Currently the "Load to Preview Deck" menu point in the library's context menu is always aktiv (clickable). But clicking the menu point does nothing if the Track load behaviour in Preferences > Interface is set to "Don't load tracks into playing decks".

For consistency with the regular/sampler decks we should decide if we
1. Always allow to load tracks into a playing Preview deck, or
2. Deactivate the "Load to Preview Deck" menu point if the track load behaviour is set to "Don't load tracks into playing decks"

My vote is for 1.
It is safe to use ( you can't produce a trainwreck while previewing trough monitor output), and we already allow it by using the preview button/midi/keyboard controls. If we'd change this, the drag and drop behaviour to a playing preview deck probably has to change as well.

[RJ Skerry-Ryan (rryan)]

My vote is #1 as well.. preview deck should not be affected by load-track-to-playing-deck preference.

[Max Linke (max-linke)]

this will produce option #1. This is a bit quick because it will only work with one previewDeck. If I have time on Monday I will make a version that works for any number of previewdecks.

Also a quick question to that. Is there a reason why m_pGroup in woverview and wwaveform is a char* instead of a QString variable?

[Max Linke (max-linke)]

tested with lp:~mixxxdevelopers/1.11-skins

[RJ Skerry-Ryan (rryan)]

Hacking it for just [PreviewDeck1] is fine ... patch looks good. thanks max

On Sat, Dec 22, 2012 at 6:28 AM, Max Linke <email address hidden>wrote:

> ** Changed in: mixxx
> Status: Confirmed => In Progress
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1092949
>
> Title:
> Decide if "Load to Preview Deck" in context menu should respect track
> load behaviour
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1092949/+subscriptions
>

[Max Linke (max-linke)]

I've commited the patch

[jus (jus)]

Thanks for the fix Max.

Just a hint:
It is helpful to associating commits and bugs using the "--fixes" option. This way the bugs are visible in the logs and automatically linked to the bug tracker. See http://doc.bazaar.canonical.com/beta/en/user-guide/bug_trackers.html

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6797