update-manager core should support proposed updates

[Michael Vogt]

Binary package hint: update-manager-core

update-manager-core does not support upgrading using the release-upgader in $distro-proposed, the attached debdiff fixes that

TEST CASE:
1. install edgy
2. run do-release-upgrade --proposed -> this option is not supported

3. install new update-manager-core
4. run do-release-upgrade --proposed
5. verify that the update continues with this option

[Michael Vogt (mvo)]

+update-manager-core (0.56~edgy5) edgy-proposed; urgency=low
+
+ * support --proposed to support upgrade using the upgrader in
+ the feisty-proposed pocket
+ * support --mode to control if the upgrader should be run in desktop
+ or server upgrade mode
+
+ -- Michael Vogt <email address hidden> Mon, 23 Apr 2007 16:53:24 +0200

[Martin Pitt (pitti)]

+ help=_("Run in a special upgrade mode"))

This does not seem to be overly helpful...

- fetcher.run_options += ["--mode=server",
+ fetcher.run_options += ["--mode=%s" % options.mode,

This looks a bit fishy, since the add_option() call does not declare a default value. Can you please clarify this?

[Michael Vogt (mvo)]

Hm, there is a default set in add_option for mode (or do I overlook something here):

+ parser.add_option ("-m", "--mode", default="server",
+ dest="mode",

About the help-text, I agree I can make that better, something like:
"Run in a special upgrade mode, currently "desktop" and "server" are supported"

[Martin Pitt (pitti)]

Right, sorry about the default, that was an oversight.

The help text is slightly better, but maybe it can explain shortly what the modes do? As a user of this tool I still don't know which one to choose.

  Set upgrade mode: "desktop" (will consider foobarization of ubuntu-desktop) or "server" (default; will ignore blabla)

[Michael Vogt (mvo)]

I uploaded this again with a corrected changelog and with updated help text.

Thanks,
 Michael

[Martin Pitt (pitti)]

Accepted into edgy-proposed, please go ahead with QA testing.

[Martin Pitt (pitti)]

This is has sitted in edgy-proposed for over 200 days already. Can it please be verified or declared as obsolete?

[Pedro Villavicencio (pedro)]

Verification done:

- Test with update-manager-core 0.45.2, it doesn't work because the option --proposed isn't supported.
- Test with update-manager-core 0.45.4, It works fine i was able to use the option and see that the update continues.

[Pedro Villavicencio (pedro)]

Versions typo:
first test was with update-manager-core 0.56~edgy4, second one with 0.56~edgy5

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:0.87.3

---------------
update-manager (1:0.87.3) hardy; urgency=low

  * add ports.ubuntu.com to the valid mirrors (LP: #184663)
  * add --proposed to the options for do-release-upgrade
    (LP: #109290)
  * fix crash in apport report duplicate checking

 -- Michael Vogt <email address hidden> Tue, 22 Jan 2008 15:50:28 +0000

[Martin Pitt (pitti)]

Copied to edgy-updates.