pygrub command does not use nova-rootwrap

Bug #1091628 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Armando Migliaccio

Bug Description

I am baffled by how this line could work:

https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vm_utils.py#L1925

when the compute worker runs as low-privilege user. This should really use the rootwrapper:

out, err = utils.execute('pygrub', '-qn', dev_path, run_as_root=True)

and have a compute filter specified like so:

pygrub: CommandFilter, /usr/bin/pygrub, root

Changed in nova:
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18312

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/18312
Committed: http://github.com/openstack/nova/commit/e6acd86b8419018f25e96f484340b7631c3e127b
Submitter: Jenkins
Branch: master

commit e6acd86b8419018f25e96f484340b7631c3e127b
Author: Armando Migliaccio <email address hidden>
Date: Tue Dec 18 14:11:16 2012 +0000

    Execute pygrub using nova-rootwrap in xenapi

    Preserve the behavior where, if pygrub fails, compute attempts
    to spawn the VM in HVM mode.

    Fixes bug #1091628

    Change-Id: Ia462964ebb1fc21d8e289de32557a2e7867f1257

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.