There are relative imports in NVP plugin

Bug #1091596 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Aaron Rosen

Bug Description

We all know how bad this is in terms of HACKING rules:

import NvpApiClient
import nvplib

However, as of the Folsom release, we saw unit test failures if we made those imports absolute.
This is not a good excuse for violating HACKING rules, so these relative imports must now go

Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
milestone: none → grizzly-2
importance: Undecided → Medium
Changed in quantum:
status: New → Confirmed
Revision history for this message
dan wendlandt (danwent) wrote :

I'll move this to G-3 later this week unless I see a patch by then. thx.

Aaron Rosen (arosen)
Changed in quantum:
assignee: Salvatore Orlando (salvatore-orlando) → Aaron Rosen (arosen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18928

Changed in quantum:
status: Confirmed → In Progress
dan wendlandt (danwent)
Changed in quantum:
milestone: grizzly-2 → grizzly-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/18928
Committed: http://github.com/openstack/quantum/commit/20ea05f5d230d1bf9e70c9cc79a1089c2e4595df
Submitter: Jenkins
Branch: master

commit 20ea05f5d230d1bf9e70c9cc79a1089c2e4595df
Author: Aaron Rosen <email address hidden>
Date: Thu Jan 3 16:52:42 2013 -0800

    Remove relative imports from NVP plugin

    The majority of relative imports in the nvp plugin will be fixed in
    blueprint nvp-api-client-loadbalance-request. This patch removes the
    rest of them in and moves the vim tabstop line to the top of the
    header file to be consistent with the rest of the files in quantum.
    Fixes bug 1091596

    Change-Id: I6c8299ca73ae5df75c87f302680908f863f81f02

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.