'show' method in the FloatingIPDNS extension does work properly

Bug #1089410 reported by Tiago Mello
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Tiago Mello

Bug Description

When calling the method v2/{tenant_id}/os-floating-ip-dns/{domain}/entries/{ip}, the 'show' method calls
'self.network_api.get_dns_entries_by_name' instead of 'self.network_api.get_dns_entries_by_address'. It turns out that no entry is returned and '_create_dns_entry(entries[0], id, domain)' fails with 'List index out of range' error.

Also, the method 'v2/{tenant_id}/os-floating-ip-dns/{domain}/entries/{ip}' should return a list of DNS entries for a given domain and IP as the documentation says.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17938

Changed in nova:
assignee: nobody → Tiago Rodrigues de Mello (tmello)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/17938
Committed: http://github.com/openstack/nova/commit/4458d1a1a6b4b6434ce7ea30479324091a393a28
Submitter: Jenkins
Branch: master

commit 4458d1a1a6b4b6434ce7ea30479324091a393a28
Author: Tiago Mello <email address hidden>
Date: Wed Dec 12 12:47:07 2012 -0200

    Fixes FloatingIPDNS extension 'show' method.

    Changes the 'show' method to also work when 'id' is actually
    an IP and calls the right method to return a list of DNS entries
    for a given domain and IP when the called method is
    'v2/{tenant_id}/os-floating-ip-dns/{domain}/entries/{ip}'.

    Fixes bug 1089410

    Change-Id: I4c424e091209624324754c548e55bbbb304cf79f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.