Mixxx won't build with hid=0

[x]

On revision 3593, I can't build Mixxx with the hid=0 flag. The reason I want this is so I can use my VMS4.1 with the MIDI mapping, as there is no HID mapping for it yet.

The build process exits with:

lin64_build/controllers/bulk/bulkcontroller.o: In function `BulkController::savePreset(QString) const':
/home/matt/BzrStuff/1.11/mixxx/src/controllers/bulk/bulkcontroller.cpp:111: undefined reference to `HidControllerPresetFileHandler::save(HidControllerPreset const&, QString, QString) const'
lin64_build/controllers/bulk/bulkcontroller.o: In function `HidControllerPresetFileHandler::HidControllerPresetFileHandler()':
/home/matt/BzrStuff/1.11/mixxx/src/controllers/hid/hidcontrollerpresetfilehandler.h:9: undefined reference to `vtable for HidControllerPresetFileHandler'
lin64_build/controllers/bulk/bulkcontroller.o: In function `HidControllerPresetFileHandler::~HidControllerPresetFileHandler()':
/home/matt/BzrStuff/1.11/mixxx/src/controllers/hid/hidcontrollerpresetfilehandler.h:10: undefined reference to `vtable for HidControllerPresetFileHandler'
collect2: error: ld returned 1 exit status
scons: *** [lin64_build/mixxx] Error 1
scons: building terminated because of errors.

The command used to compile is :

scons qtdir=/usr/share/qt/ tuned=1 hid=0

[RJ Skerry-Ryan (rryan)]

We should fix this, but you should be able to use the VMS4 with MIDI even with hid=1. Both subsystems co-exist in Mixxx. Do you see multiple VMS4's in the device list or just one? What is the "type" it says it is.

[x (broma0-deactivatedaccount)]

When built without hid=0, I only see one VMS4.1 device and it is listed as
HID. I figured it should show up as two different devices but for some
reason I cant get it to.

On Sun, Dec 9, 2012 at 7:00 PM, RJ Ryan <email address hidden> wrote:

> We should fix this, but you should be able to use the VMS4 with MIDI
> even with hid=1. Both subsystems co-exist in Mixxx. Do you see multiple
> VMS4's in the device list or just one? What is the "type" it says it is.
>
> ** Also affects: mixxx/1.11
> Importance: Undecided
> Status: New
>
> ** Changed in: mixxx/1.11
> Importance: Undecided => Low
>
> ** Changed in: mixxx
> Importance: Undecided => Low
>
> ** Changed in: mixxx/1.11
> Milestone: None => 1.11.0
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1088263
>
> Title:
> Mixxx won't build with hid=0
>
> Status in Mixxx:
> New
> Status in Mixxx 1.11 series:
> New
>
> Bug description:
> On revision 3593, I can't build Mixxx with the hid=0 flag. The reason
> I want this is so I can use my VMS4.1 with the MIDI mapping, as there
> is no HID mapping for it yet.
>
> The build process exits with:
>
> lin64_build/controllers/bulk/bulkcontroller.o: In function
> `BulkController::savePreset(QString) const':
>
> /home/matt/BzrStuff/1.11/mixxx/src/controllers/bulk/bulkcontroller.cpp:111:
> undefined reference to
> `HidControllerPresetFileHandler::save(HidControllerPreset const&, QString,
> QString) const'
> lin64_build/controllers/bulk/bulkcontroller.o: In function
> `HidControllerPresetFileHandler::HidControllerPresetFileHandler()':
>
> /home/matt/BzrStuff/1.11/mixxx/src/controllers/hid/hidcontrollerpresetfilehandler.h:9:
> undefined reference to `vtable for HidControllerPresetFileHandler'
> lin64_build/controllers/bulk/bulkcontroller.o: In function
> `HidControllerPresetFileHandler::~HidControllerPresetFileHandler()':
>
> /home/matt/BzrStuff/1.11/mixxx/src/controllers/hid/hidcontrollerpresetfilehandler.h:10:
> undefined reference to `vtable for HidControllerPresetFileHandler'
> collect2: error: ld returned 1 exit status
> scons: *** [lin64_build/mixxx] Error 1
> scons: building terminated because of errors.
>
> The command used to compile is :
>
> scons qtdir=/usr/share/qt/ tuned=1 hid=0
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1088263/+subscriptions
>

--
Matt Brooks

[Max Linke (max-linke)]

This is because the Bulk feature right now depends on hid. Is this desired?

compiling with hid=0 and bulk=0 works.

[Daniel Schürmann (daschuer)]

I have added hidcontrollerpresetfilehandler.cpp to bulk feature if hid=0.
Committed to lp:mixxx/1.11 revision 3784.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6764