Cinder

Root wrap tools used by NFS volume driver

Bug #1087282 reported by Carlos Goncalves on 2012-12-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	High	Carlos Goncalves	Cinder 2013.1 "grizzly"
	Folsom	Fix Released	High	Eric Harney	Cinder 2012.2.3

Bug Description

The NFS volume driver requires some tools to be executed as root. Those tools need to be root-wrapped.

2012-12-06 14:37:00 17821 DEBUG cinder.openstack.common.rpc.amqp [-] received {u'_context_roles': [u'KeystoneAdmin', u'admin', u'KeystoneServiceAdmin'], u'_context_request_id': u'req-ab611554-e2cd-4080-800c-b696e1b3787d', u'_context_quota_class': None, u'args': {u'image_id': None, u'snapshot_id': None, u'volume_id': u'c3e8cf4e-ff96-4bb2-ba16-80e00b1bfdb8'}, u'_context_auth_token': '<SANITIZED>', u'_context_is_admin': True, u'_context_project_id': u'8902fbe59dfd403e908b40ebc3e8e021', u'_context_timestamp': u'2012-12-06T14:37:00.678153', u'_context_read_deleted': u'no', u'_context_user_id': u'7cbd81ed6e8d45dcb69eb7ddbdac418d', u'method': u'create_volume', u'_context_remote_address': u'193.136.92.86'} _safe_log /usr/lib/python2.7/dist-packages/cinder/openstack/common/rpc/common.py:195
2012-12-06 14:37:00 17821 DEBUG cinder.openstack.common.rpc.amqp [-] unpacked context: {'user_id': u'7cbd81ed6e8d45dcb69eb7ddbdac418d', 'roles': [u'KeystoneAdmin', u'admin', u'KeystoneServiceAdmin'], 'timestamp': u'2012-12-06T14:37:00.678153', 'auth_token': '<SANITIZED>', 'remote_address': u'193.136.92.86', 'quota_class': None, 'is_admin': True, 'request_id': u'req-ab611554-e2cd-4080-800c-b696e1b3787d', 'project_id': u'8902fbe59dfd403e908b40ebc3e8e021', 'read_deleted': u'no'} _safe_log /usr/lib/python2.7/dist-packages/cinder/openstack/common/rpc/common.py:195
2012-12-06 14:37:00 INFO cinder.volume.manager [req-ab611554-e2cd-4080-800c-b696e1b3787d 7cbd81ed6e8d45dcb69eb7ddbdac418d 8902fbe59dfd403e908b40ebc3e8e021] volume volume-c3e8cf4e-ff96-4bb2-ba16-80e00b1bfdb8: creating
2012-12-06 14:37:00 DEBUG cinder.volume.manager [req-ab611554-e2cd-4080-800c-b696e1b3787d 7cbd81ed6e8d45dcb69eb7ddbdac418d 8902fbe59dfd403e908b40ebc3e8e021] volume volume-c3e8cf4e-ff96-4bb2-ba16-80e00b1bfdb8: creating lv of size 1G create_volume /usr/lib/python2.7/dist-packages/cinder/volume/manager.py:133
2012-12-06 14:37:00 DEBUG cinder.utils [req-ab611554-e2cd-4080-800c-b696e1b3787d 7cbd81ed6e8d45dcb69eb7ddbdac418d 8902fbe59dfd403e908b40ebc3e8e021] Running cmd (subprocess): sudo cinder-rootwrap /etc/cinder/rootwrap.conf stat /mnt/nas/8db673f3f04894fa96f1c5c55463eeae execute /usr/lib/python2.7/dist-packages/cinder/utils.py:156
2012-12-06 14:37:01 DEBUG cinder.utils [req-ab611554-e2cd-4080-800c-b696e1b3787d 7cbd81ed6e8d45dcb69eb7ddbdac418d 8902fbe59dfd403e908b40ebc3e8e021] Result was 99 execute /usr/lib/python2.7/dist-packages/cinder/utils.py:172
2012-12-06 14:37:01 WARNING cinder.volume.driver [req-ab611554-e2cd-4080-800c-b696e1b3787d 7cbd81ed6e8d45dcb69eb7ddbdac418d 8902fbe59dfd403e908b40ebc3e8e021] Exception during mounting Unexpected error while running command.
Command: sudo cinder-rootwrap /etc/cinder/rootwrap.conf stat /mnt/nas/8db673f3f04894fa96f1c5c55463eeae
Exit code: 99
Stdout: 'Unauthorized command: stat /mnt/nas/8db673f3f04894fa96f1c5c55463eeae\n'
Stderr: ''
2012-12-06 14:37:01 DEBUG cinder.volume.driver [req-ab611554-e2cd-4080-800c-b696e1b3787d 7cbd81ed6e8d45dcb69eb7ddbdac418d 8902fbe59dfd403e908b40ebc3e8e021] Available shares [] _ensure_shares_mounted /usr/lib/python2.7/dist-packages/cinder/volume/nfs.py:200
2012-12-06 14:37:01 17821 ERROR cinder.openstack.common.rpc.amqp [-] Exception during message handling
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp Traceback (most recent call last):
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/cinder/openstack/common/rpc/amqp.py", line 276, in _process_data
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/cinder/openstack/common/rpc/dispatcher.py", line 145, in dispatch
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/cinder/volume/manager.py", line 163, in create_volume
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp volume_ref['id'], {'status': 'error'})
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp self.gen.next()
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/cinder/volume/manager.py", line 135, in create_volume
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp model_update = self.driver.create_volume(volume_ref)
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/cinder/volume/nfs.py", line 84, in create_volume
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp volume['provider_location'] = self._find_share(volume['size'])
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/dist-packages/cinder/volume/nfs.py", line 220, in _find_share
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp raise exception.NfsNoSharesMounted()
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp NfsNoSharesMounted: No mounted NFS shares found
2012-12-06 14:37:01 17821 TRACE cinder.openstack.common.rpc.amqp

Carlos Goncalves (cgoncalves) on 2012-12-06

Changed in cinder:
assignee:	nobody → Carlos Gonçalves (cgoncalves)
status:	New → In Progress

John Griffith (john-griffith) on 2012-12-07

Changed in cinder:
status:	In Progress → Triaged
importance:	Undecided → High
milestone:	none → grizzly-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-12-10: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17762

Changed in cinder:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-12-10: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/17762
Committed: http://github.com/openstack/cinder/commit/65b3421f4b66b1e26be54f4bcb93fd3f6c7fb6f8
Submitter: Jenkins
Branch: master

commit 65b3421f4b66b1e26be54f4bcb93fd3f6c7fb6f8
Author: Carlos Goncalves <email address hidden>
Date: Thu Dec 6 14:50:29 2012 +0000

Add commands used by NFS volume driver to rootwrap

Fixes bug 1087282

Change-Id: Ib873c334633b4d586c2e53bac5d1cae0dcf65be7

Changed in cinder:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2013-01-09

Changed in cinder:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-01-16: Fix proposed to cinder (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/19862

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-01-17: Fix merged to cinder (stable/folsom)

Reviewed: https://review.openstack.org/19862
Committed: http://github.com/openstack/cinder/commit/cdf6c1398a1f5a57799b9532a4fc9a13f6eed2d4
Submitter: Jenkins
Branch: stable/folsom

commit cdf6c1398a1f5a57799b9532a4fc9a13f6eed2d4
Author: Carlos Goncalves <email address hidden>
Date: Thu Dec 6 14:50:29 2012 +0000

Add commands used by NFS volume driver to rootwrap

Fixes bug 1087282

Change-Id: Ib873c334633b4d586c2e53bac5d1cae0dcf65be7
(cherry picked from commit 65b3421f4b66b1e26be54f4bcb93fd3f6c7fb6f8)

tags:

added: in-stable-folsom

Mark McLoughlin (markmc) on 2013-01-22

tags:

removed: in-stable-folsom

Thierry Carrez (ttx) on 2013-04-04

Changed in cinder:
milestone:	grizzly-2 → 2013.1

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.