libvirt: Two Ephemeral backing files are created in base

Bug #1087028 reported by Vish Ishaya
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Michael Still

Bug Description

When ephemeral disks are created, a second copy is made. This seems to be due to the caching code in imagebackend.

in _base:

ephemeral_0_20_None
ephemeral_0_20_None_20

Changed in nova:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Michael Still (mikalstill)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17656

Changed in nova:
status: Triaged → In Progress
Revision history for this message
Pádraig Brady (p-draigbrady) wrote :

This looks like a folsom regression so a backport candidate?
Looking at what I did in nova.virt.libvirt.connection._cache_image() in essex:

    generating = 'image_id' not in kwargs
    ...
        if cow or not generating:
            call_if_not_exists(base, fn, *args, **kwargs)
        elif generating:
            # For raw it's quicker to just generate outside the cache
            call_if_not_exists(target, fn, *args, **kwargs)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/17656
Committed: http://github.com/openstack/nova/commit/e28d7870fa8633fddd5fe92d2fbcc34ae392bd85
Submitter: Jenkins
Branch: master

commit e28d7870fa8633fddd5fe92d2fbcc34ae392bd85
Author: Michael Still <email address hidden>
Date: Thu Dec 6 14:04:51 2012 +1100

    Simplify how ephemeral disks are created and named.

    Resolves bug 1087028.

    Change-Id: Ife7ec43cf76cf04a98f1db2135f9149a2eefb55d

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17815

Michael Still (mikal)
Changed in nova:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/17815
Committed: http://github.com/openstack/nova/commit/a829da8111520e38a3ce400ba35307f685dad0b2
Submitter: Jenkins
Branch: master

commit a829da8111520e38a3ce400ba35307f685dad0b2
Author: Michael Still <email address hidden>
Date: Tue Dec 11 11:08:51 2012 +1100

    Revert "Simplify how ephemeral disks are created and named."

    This reverts commit e28d7870fa8633fddd5fe92d2fbcc34ae392bd85.

    This needs another attempt. Associated with bug 1087028.

    Change-Id: I5822b8934d4a944299ef32960bc56718193c32c3

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.