Weird inconsistent param list url logic used in some clients

[Matthew Treinish]

In certain functions there is some weird param list functions used to generate a url with params. Instead of the more sane:

url += '?%s' % urllib.urlencode(params)

Grepping all the clients in tempest/services I found these being used:

tempest/services/compute/json/volumes_extensions_client.py: url += '?' + ' '.join(param_list)
tempest/services/compute/json/security_groups_client.py: url += '?' + ' &'.join(param_list)
tempest/services/compute/json/floating_ips_client.py: url += '?' + ' &'.join(param_list)
tempest/services/compute/xml/security_groups_client.py: url += '?' + ' &'.join(param_list)
tempest/services/compute/xml/servers_client.py: url += "?" + "&".join(param_list)
tempest/services/compute/xml/servers_client.py: url += "?" + "&".join(param_list)
tempest/services/compute/xml/floating_ips_client.py: url += "?" + "&".join(param_list)
tempest/services/object_storage/container_client.py: url += '?' + ''.join(param_list)
tempest/services/volume/json/volumes_client.py: url += '?' + ' '.join(param_list)

These should all be made consistent and use urllib.urlencode.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/17513

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/17513
Committed: http://github.com/openstack/tempest/commit/26dd0fac5c8bd6147f559eccccbef2cbca703b7a
Submitter: Jenkins
Branch: master

commit 26dd0fac5c8bd6147f559eccccbef2cbca703b7a
Author: Matthew Treinish <email address hidden>
Date: Tue Dec 4 17:14:37 2012 -0500

    Make parameter list generation consistent using urlencode().

    Ensure that each client is generating the parameter list
    correctly by using the urllib.urlencode method.

    Fixes: bug 1086574
    Change-Id: I9008a57fe94ccec1f3bea95f314860ff8017cb42