Designate

mysqlbind: deletion of a record uses non-unique 'name' column

Bug #1086467 reported by CaptTofu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
CaptTofu
Designate grizzly-1

Bug Description

when deleting a specific record, the code uses 'name' as the field to delete on, but 'name' is non-unique. This could result in deleting more records than intended.

The fix is to add a column to 'dns_domains' that is a foreign key to moniker 'records' id column, since a record gives this for free.

CaptTofu (capttofu)
Changed in moniker:
assignee: nobody → CaptTofu (capttofu)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to moniker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17486

Changed in moniker:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to moniker (master)

Reviewed: https://review.openstack.org/17486
Committed: http://github.com/stackforge/moniker/commit/fccd88521af9538a295445acdd835715c22cf834
Submitter: Jenkins
Branch: master

commit fccd88521af9538a295445acdd835715c22cf834
Author: Patrick Galbraith <email address hidden>
Date: Mon Dec 3 14:11:43 2012 +0000

    bug #1086467, fixed by using moniker record ID in dns_domains column.

    Change-Id: Iae156f379c4b873c09200d479e9edcaa4c54f6a6

Changed in moniker:
status: In Progress → Fix Committed
Kiall Mac Innes (kiall)
Changed in moniker:
milestone: none → grizzly-1
Kiall Mac Innes (kiall)
Changed in designate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.