OS_CA_CERT is not consistent with help message

Bug #1086278 reported by hill
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Low
Wu Wenxiang

Bug Description

python-keystoneclient/keystoneclient/shell.py

line 151

 parser.add_argument('--os-cacert',
                            metavar='<ca-certificate>',
                            default=env('OS_CA_CERT', default=None),
                            help='Defaults to env[OS_CACERT]')
        parser.add_argument('--os_cacert',
                            help=argparse.SUPPRESS)

    the help message is OS_CACERT , but the code will read from OS_CA_CERT , need to be consistent

     suggest to change the OS_CA_CERT to OS_CACERT

Changed in python-keystoneclient:
assignee: nobody → Wu Wenxiang (wu-wenxiang)
status: New → In Progress
Revision history for this message
Wu Wenxiang (wu-wenxiang) wrote :

https://review.openstack.org/17661

Change ca-certificate default value from env[OS_CA_CERT] to env[OS_CACERT] (bug/1086278)

Change-Id: I0a502069cd3743f812c8145cbce73cd091e57de6

Changed in python-keystoneclient:
assignee: Wu Wenxiang (wu-wenxiang) → Dolph Mathews (dolph)
Dolph Mathews (dolph)
Changed in python-keystoneclient:
assignee: Dolph Mathews (dolph) → Wu Wenxiang (wu-wenxiang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/17661
Committed: http://github.com/openstack/python-keystoneclient/commit/581264757e5ac8c5313acc35e5dc94247c7a80ff
Submitter: Jenkins
Branch: master

commit 581264757e5ac8c5313acc35e5dc94247c7a80ff
Author: Wu Wenxiang <wu.wenxiang@99cloud.net>
Date: Fri Dec 7 12:43:30 2012 +0800

    modify ca-certificate default value

    modify the value from env[OS_CA_CERT] to env[OS_CACERT] to ensure the help message and codes keep consistent.

    Fixes: bug 1086278

    Change-Id: I0a502069cd3743f812c8145cbce73cd091e57de6

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.2.1
importance: Undecided → Low
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.