"Create-port" API returns internal server error when allocation_pool's ip address are drained.

[Rikimaru Honjo]

"Port creation" API returns internal server error when allocation_pool's ip address drained.
I think "500 internal server error" is unsuitable in this case.

I saw following page, but this case is not defined.
http://docs.openstack.org/api/openstack-network/2.0/content/Create_Port.html

I think this case should return "409" or "503".
(But, I cannot decide "409 " or "503".)

[dan wendlandt (danwent)]

yeah, this is a bug. It should be something in the 400s I suspect, as the server is behaving correctly, and it is up to the tenant to remedy the situation.

409 seems like a reasonable solution, though I usually think of it as being used when the tenant is making a request that would put the system in an inconsistent state. Another option would just be to return a generic 400 request.

salvatore (API guru) should probably figure out which is more consistent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/17466

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/17466
Committed: http://github.com/openstack/quantum/commit/b939b0749a1a37400702286d19951d1682abccc7
Submitter: Jenkins
Branch: master

commit b939b0749a1a37400702286d19951d1682abccc7
Author: Gary Kotton <email address hidden>
Date: Tue Dec 4 14:41:41 2012 +0000

    Returns more appropriate error when address pool is exhausted

    Fixes bug 1086226

    Change-Id: I97a73151a1ed42877116238a6a741c68c75e199a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/18647