Preview button in library re-loads tracks on every mouse-down, no way to stop playback

[jus]

Tested with latest lp:mixxx/1.11

How to reproduce:
* Activate "Preview" column header in library table
* Select a track and press the Preview button
* Track is loaded to the (invisible) preview deck and starts to play
* Press the Preview button again

Expected behavior:
* Playback stops and track unloads from Preview deck

Actual behavior:
* Track is loaded again into the preview deck and playback stops only if the track reaches its end

While we can use the play/pause button on the visible previewdeck do halt the playback, imo it would be practical to have the said functionality for the preview button. This way you could rapidly scan trough your tracks without the need to have a Preview Deck visible to stop the playback. Another benefit would be that we can connect the Preview button to a Keyboard shortcut.

[Max Linke (max-linke)]

I've added a patch that should produce your desired behaviour

[RJ Skerry-Ryan (rryan)]

Thanks Max! Instead of storing the track in the Handler you should use PlayerInfo::getTrackInfo("[PreviewDeck1]"). That way if someone drags a track to a preview deck via the Overview or right-click -> Load to Preview Deck then you will always be checking against the currently loaded track.

[Max Linke (max-linke)]

Like this?

[RJ Skerry-Ryan (rryan)]

Yep, LGTM. Please commit to lp:mixxx/1.11

On Thu, Nov 29, 2012 at 12:15 PM, Max Linke <email address hidden>wrote:

> Like this?
>
> ** Patch added: "preview_v2.patch"
>
> https://bugs.launchpad.net/mixxx/+bug/1084460/+attachment/3447074/+files/preview_v2.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1084460
>
> Title:
> Preview button in library re-loads tracks on every mouse-down, no way
> to stop playback
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1084460/+subscriptions
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6723