lxc-clone shouldn't add fstab line if it wasn't there originally
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lxc (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Precise |
Fix Released
|
High
|
Unassigned | ||
Quantal |
Fix Released
|
High
|
Unassigned | ||
Raring |
Fix Released
|
High
|
Unassigned |
Bug Description
=======
SRU Justification:
1. Impact: lxc-clone can produce non-functional containers
2. Development fix: fix lxc-clone's handling of updates to lxc.mount entries.
3. Stable fix: same as development fix
4. Test case:
lxc-create -t ubuntu -n c1
sudo sed -i 's/lxc.mount =/lxc.mount =/' /var/lib/
sudo lxc-clone -o c1 -n c2
grep fstab /var/lib/
5. Regression potential: only lxc-clone is updated, so regressions would be
contained in lxc-clone and in the code which is already broken for updating
lxc.mount.
=======
Rene K. Mueller reports that when an original container does not have an fstab, lxc-clone still adds a 'lxc.mount = ..../fstab' line, breaking container start.
Related branches
Changed in lxc (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
tags: | added: needssru |
Changed in lxc (Ubuntu Quantal): | |
assignee: | nobody → Serge Hallyn (serge-hallyn) |
status: | Triaged → In Progress |
Changed in lxc (Ubuntu Precise): | |
status: | Triaged → In Progress |
assignee: | nobody → Serge Hallyn (serge-hallyn) |
description: | updated |
Changed in lxc (Ubuntu Precise): | |
assignee: | Serge Hallyn (serge-hallyn) → nobody |
Changed in lxc (Ubuntu Quantal): | |
assignee: | Serge Hallyn (serge-hallyn) → nobody |
While fixing this one, can you also have lxc-clone properly change the lxc.mount line to point to the clone (if lxc.mount exists for the source).
I thought that was done, but apparently not, I spent half an hour yesterday trying to figure out why a container was ignoring new fstab entries, before noticing that lxc.mount was pointing at another container...