SSHGitClient doesn't support username expansion

[Eugene]

TCPGitClient has the following two lines for supporting URLs like ssh://host.xz/~user/repo:
        if path.startswith("/~"):
            path = path[1:]

git does something similar in connect.c:568.

These two lines should be added to the start of SSHGitClient._connect. Otherwise I can't clone my OpenShift git repository with the URL that they provide.

Thanks!
Eugene

[milki (milki-p)]

Implemented the suggested solution.

No tests made because I am not sure of how to emulate the behaviour and there is no existing test for TCPGitClient.

[Jelmer Vernooij (jelmer)]

On Thu, 2013-01-10 at 04:07 +0000, milki wrote:
> Implemented the suggested solution.
>
> No tests made because I am not sure of how to emulate the behaviour and
> there is no existing test for TCPGitClient.
>
> ** Patch added: "0001-Support-username-expansion-in-SSHGitClient.patch"
> https://bugs.launchpad.net/dulwich/+bug/1083439/+attachment/3478736/+files/0001-Support-username-expansion-in-SSHGitClient.patch
That looks reasonable to me - though a test would be really nice...

Cheers,

Jelmer

[milki (milki-p)]

I've attached a test that mocks SSHVendor. I made a fake class for the return value of connect_ssh to make _connect happy. I don't know if that should be done...

[Jelmer Vernooij (jelmer)]

On Sat, 2013-01-19 at 05:26 +0000, milki wrote:
> I've attached a test that mocks SSHVendor. I made a fake class for the
> return value of connect_ssh to make _connect happy. I don't know if that
> should be done...
>
> ** Patch added: "0002-Add-test_connect-for-SSHGitClient.patch"
> https://bugs.launchpad.net/dulwich/+bug/1083439/+attachment/3488408/+files/0002-Add-test_connect-for-SSHGitClient.patch
>
Thanks for the patches. I've been really distracted with other things
recently, but these are on my review queue.

Sorry for the delay.

Cheers,

Jelmer

[Jelmer Vernooij (jelmer)]

Merged, thanks.