Glance

Disabling run_tests pep8

Bug #1080907 reported by Joshua Harlow
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Wishlist
Joshua Harlow
Glance grizzly-2 "g2"
Grizzly
Fix Released
Wishlist
Joshua Harlow
Glance 2013.1 "grizzly"

Bug Description

It seems like the "-P, --no-pep8" option was removed from run_tests.sh (?)

It would be great to have this back in, as not everyone wants to run pep8 (especially when there are different versions of pep8 being included by the different components of openstack, causing differing levels of messaging/errors/warnings...)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16494

Changed in glance:
assignee: nobody → Joshua Harlow (harlowja)
status: New → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Wishlist
Revision history for this message
Joshua Harlow (harlowja) wrote :

Hmmm, the other components are using the same format, so why is this pushed to 'wishlist'?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/16494
Committed: http://github.com/openstack/glance/commit/5018ebfdc9df6b4e6dc443a24ff23983e70eb125
Submitter: Jenkins
Branch: master

commit 5018ebfdc9df6b4e6dc443a24ff23983e70eb125
Author: Joshua Harlow <email address hidden>
Date: Mon Nov 19 15:26:54 2012 -0800

    Allow for not running pep8.

    Its not always wanted to run pep8 so we should have
    a flag that can be used to disable it so that people
    who do not want to run it can accomplish this.

    Fixes: bug 1080907

    Change-Id: I7f9dedbc7eca8421e0acf58e478c105f8b8de0c9

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.