Mahara

directoryiterator error prevents upgrading

Bug #1080498 reported by Melissa Draper
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Melissa Draper
Mahara 1.6.2
1.7
Fix Released
High
Unassigned
Mahara 1.7.1

Bug Description

For more information, see:
https://mahara.org/interaction/forum/topic.php?id=5054#post21975

Hugh Davenport (hugh-davenport)
Changed in mahara:
status: New → Triaged
importance: Undecided → Low
milestone: none → 1.6.2
importance: Low → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1861
Committed: http://gitorious.org/mahara/mahara/commit/6c3b6edaeb3ee6ff407ceb4f6b4fa8bad9fcc258
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit 6c3b6edaeb3ee6ff407ceb4f6b4fa8bad9fcc258
Author: Melissa Draper <email address hidden>
Date: Wed Nov 21 13:19:01 2012 +1300

    Check originals directory before iterator in upgrade (Bug #1080498)

    If no "original" files had been created via uploads yet, the base
    directory was absent, causing the directoryiterator to fail.

    Change-Id: I77741f5f8c154a4afdb7b26846dd1aac4356ac72
    Signed-off-by: Melissa Draper <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1862
Committed: http://gitorious.org/mahara/mahara/commit/ada4321041d81f7ea493482867e2b6141aec77d7
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.5_STABLE

commit ada4321041d81f7ea493482867e2b6141aec77d7
Author: Melissa Draper <email address hidden>
Date: Wed Nov 21 13:19:01 2012 +1300

    Check originals directory before iterator in upgrade (Bug #1080498)

    If no "original" files had been created via uploads yet, the base
    directory was absent, causing the directoryiterator to fail.

    Change-Id: I77741f5f8c154a4afdb7b26846dd1aac4356ac72
    Signed-off-by: Melissa Draper <email address hidden>

Hugh Davenport (hugh-davenport)
Changed in mahara:
status: Triaged → Fix Released
assignee: nobody → Melissa Draper (melissa)
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1863
Committed: http://gitorious.org/mahara/mahara/commit/b3d99328064d110155c10f2ba97f93a60657a1b0
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit b3d99328064d110155c10f2ba97f93a60657a1b0
Author: Melissa Draper <email address hidden>
Date: Wed Nov 21 13:19:01 2012 +1300

    Check originals directory before iterator in upgrade (Bug #1080498)

    If no "original" files had been created via uploads yet, the base
    directory was absent, causing the directoryiterator to fail.

    Change-Id: I77741f5f8c154a4afdb7b26846dd1aac4356ac72
    Signed-off-by: Melissa Draper <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2130
Committed: http://gitorious.org/mahara/mahara/commit/305d3aed01dc8481df670a9f11e824ee9b649fc8
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.7_STABLE

commit 305d3aed01dc8481df670a9f11e824ee9b649fc8
Author: Melissa Draper <email address hidden>
Date: Wed Nov 21 13:19:01 2012 +1300

Check originals directory before iterator in upgrade (Bug #1080498)

If no "original" files had been created via uploads yet, the base
directory was absent, causing the directoryiterator to fail.

Change-Id: I77741f5f8c154a4afdb7b26846dd1aac4356ac72
Signed-off-by: Aaron Wells <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2131
Committed: http://gitorious.org/mahara/mahara/commit/2ae5cd5f267fb7f43e4c7ae33fba6b3f44092f42
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 2ae5cd5f267fb7f43e4c7ae33fba6b3f44092f42
Author: Aaron Wells <email address hidden>
Date: Thu May 2 16:52:40 2013 +1200

Revert "Bug 1170587: Set mkdir() to create intermediate directories"

Replacing with a patch from Bug 1080498

This reverts commit bb099ec633f29a163b5458afefe2bfa5bdce0394

Change-Id: Ia19abc3271424c34a23a855abfff952b6a5e93eb

Revision history for this message
Aaron Wells (u-aaronw) wrote :

For some reason an older version of the patch, using mkdir() was pushed to the master branch, rather than the later one that uses check_dir_exists. Consequently, the patch could error out during installation or upgrade in 1.7_STABLE and master.

Before I discovered this, I created another patch under https://bugs.launchpad.net/mahara/+bug/1170587 . But I like the patch from here better because it has an exception catching block. So, I've ported it to 1.7_STABLE and master

master: https://reviews.mahara.org/#/c/2132/
1.7: https://reviews.mahara.org/#/c/2130/

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2132
Committed: http://gitorious.org/mahara/mahara/commit/ab5f6c61dfef2478ffb884adf25c7735e4c3e1ec
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit ab5f6c61dfef2478ffb884adf25c7735e4c3e1ec
Author: Melissa Draper <email address hidden>
Date: Wed Nov 21 13:19:01 2012 +1300

Check originals directory before iterator in upgrade (Bug #1080498)

If no "original" files had been created via uploads yet, the base
directory was absent, causing the directoryiterator to fail.

Change-Id: Ic9d5509cdfe002641759a045bea14c541b7dac56
Signed-off-by: Aaron Wells <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.