split function is deprecated but still used

Bug #1079451 reported by Hugh Davenport
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Son Nguyen

Bug Description

http://php.net/manual/en/function.split.php

One example is htdocs/lib/mahara.php line 1046

Tags: deprecation
Revision history for this message
Son Nguyen (ngson2000) wrote :

According to the tip on PHP.net, split() will be replaced by explode() if using a string as a delimiter and by preg_split() if using regular expression

Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
status: Triaged → In Progress
Revision history for this message
Son Nguyen (ngson2000) wrote :
Revision history for this message
Son Nguyen (ngson2000) wrote :

Some deprecated functions should not be in the code.

1. Deprecated functions in Php 5.4: http://php.net/manual/en/migration54.deprecated.php
2. Deprecated features in Php 5.3: http://php.net/manual/en/migration53.deprecated.php

Should we check these as minaccept when committing a code?

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1848
Committed: http://gitorious.org/mahara/mahara/commit/e00859432b81ef5a0ee5b4649e269d8b4cd85cc4
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit e00859432b81ef5a0ee5b4649e269d8b4cd85cc4
Author: Son Nguyen <email address hidden>
Date: Tue Nov 20 09:15:07 2012 +1300

    Replace the deprecated split() (Bug #1079451)

    split() will be replaced by explode() if using a string as a delimiter
    and by preg_split() if using regular expression

    Change-Id: I93a84150197fb290f89a04f10d5f0fd1e380f0da
    Signed-off-by: Son Nguyen <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.