NotAuthorized/NotAuthenticated redirect doesn't honour settings.LOGIN_URL

[Kieran Spear]

We're using a custom login view as our default auth page, but the HorizonMiddleware exception handler hardcodes the name of the login view as "login". So redirects don't go to our page.

if isinstance(exception, (exceptions.NotAuthorized,
                                  exceptions.NotAuthenticated)):
            auth_url = reverse("login")
[...]
            return shortcuts.redirect(redirect_to)

The django login_required decorator redirects to settings.LOGIN_URL if it is set, and this code should probably do the same.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/16287

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/16287
Committed: http://github.com/openstack/horizon/commit/3fbe68f690f86a9e07d054daafedf980217827e9
Submitter: Jenkins
Branch: master

commit 3fbe68f690f86a9e07d054daafedf980217827e9
Author: Kieran Spear <email address hidden>
Date: Fri Nov 16 17:20:51 2012 +1100

    Honour LOGIN_URL when redirecting to login page

    Currently the redirect is always made to the url of the 'login' view.
    This change makes redirects go to LOGIN_URL, so the default login view
    can be replaced with a view at another url/name.

    Fixes bug 1079444.

    Change-Id: Ib56200679668dd053d3c6ac24807d2a2affc0df8