Tools let --set-vars clobber the required SQL mode
Bug #1078887 reported by
Raghavendra D Prabhu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser |
Bug Description
Currently providing SQL_MODE with --set-vars clobbers the one set by the script which is "NO_AUTO_
This was discussed under -- https:/
and http://
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-1078887-DSNParser-set-vars-sql_mode-clobber
- Daniel Nichter: Approve
- Brian Fraser (community): Approve
-
Diff: 1249 lines (+324/-295)28 files modifiedbin/pt-archiver (+13/-13)
bin/pt-config-diff (+13/-13)
bin/pt-deadlock-logger (+13/-13)
bin/pt-diskstats (+1/-1)
bin/pt-duplicate-key-checker (+13/-13)
bin/pt-fifo-split (+1/-1)
bin/pt-find (+13/-13)
bin/pt-fingerprint (+1/-1)
bin/pt-fk-error-logger (+13/-13)
bin/pt-heartbeat (+13/-13)
bin/pt-index-usage (+13/-13)
bin/pt-kill (+13/-13)
bin/pt-log-player (+13/-13)
bin/pt-online-schema-change (+13/-13)
bin/pt-query-advisor (+13/-13)
bin/pt-query-digest (+12/-12)
bin/pt-show-grants (+13/-13)
bin/pt-slave-delay (+13/-13)
bin/pt-slave-find (+13/-13)
bin/pt-slave-restart (+13/-13)
bin/pt-table-checksum (+13/-13)
bin/pt-table-sync (+27/-19)
bin/pt-tcp-model (+1/-1)
bin/pt-trend (+1/-1)
bin/pt-upgrade (+13/-13)
bin/pt-variable-advisor (+13/-13)
lib/DSNParser.pm (+14/-12)
t/lib/DSNParser.t (+19/-0)
Changed in percona-toolkit: | |
milestone: | none → 2.1.8 |
importance: | Undecided → Medium |
Changed in percona-toolkit: | |
assignee: | nobody → Brian Fraser (fraserbn) |
status: | Triaged → In Progress |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
summary: |
- Don't clobber the sql_mode set by the script with set-vars + Tools let --set-vars clobber the required SQL mode |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
That's odd, I could've sworn I had made a bug after we talked on IRC, but I can't find it now. Thanks for the follow-up!