Unitest test_l3_plugin.L3NatExtensionTestCase.test_router_list with wrong fake return value

Bug #1077879 reported by Alex Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Alex Xu

Bug Description

The fake value 'return_value = [{'router': {'name': 'router1', 'admin_state_up':True, 'tenant_id': _uuid(), 'id': router_id}}]' was wrong

Suggest the fake value should be 'return_value = [{'name': 'router1', 'admin_state_up': True,'tenant_id': _uuid(), 'id': router_id}]'

And this bug relative with: https://bugs.launchpad.net/quantum/+bug/1077876

Alex Xu (xuhj)
description: updated
Revision history for this message
Alex Xu (xuhj) wrote :

When adding page link parse for coding pagination patch, found this test-case will failed. Because it the fake return value was wrong.

Changed in quantum:
assignee: nobody → Alex Xu (xuhj)
status: New → Confirmed
Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/15614
Committed: http://github.com/openstack/quantum/commit/f6da0e4edae7420c614e06f29fb088b90be338b5
Submitter: Jenkins
Branch: master

commit f6da0e4edae7420c614e06f29fb088b90be338b5
Author: He Jie Xu <email address hidden>
Date: Thu Nov 8 12:43:22 2012 +0800

    Fix unitest test_router_list with wrong fake return value

    Fixes bug 1077879

    The object of return list shouldn't wrap in 'router'

    Change-Id: I26862088f55a8d674bf22d66c7aeda1ca8fb1f98

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.