Accessing profile pictures report a nonrecoverable error on prefixed tables

[Ali Hastie]

When accessing Mahara 1.6.1 Content >> Profile pictures it states 'A nonrecoverable error occured. This probably means you have encoutered a bug in the system'.

It also states'No images found' and when I try yo upload an image, page refreshed with no image uploaded and stating the nonrecoverable error and 'No images found'.

Found this within Apache error logs:

Call stack (most recent first):, referer: http://mahara.barony.ac.uk/artefact/file/profileicons.php

* get_recordset_sql("SELECT a.id, a.title, a.note, (u.profileicon = a.i...", array(size 1), "", "") at /data/httpdata/v-hosts/mahara.barony.ac.uk/htdocs/lib/dml.php:667, referer: http://mahara.barony.ac.uk/artefact/file/profileicons.php

* get_records_sql_array("SELECT a.id, a.title, a.note, (u.profileicon = a.i...", array(size 1)) at /data/httpdata/v-hosts/mahara.barony.ac.uk/htdocs/artefact/file/profileicons.json.php:41, referer: http://mahara.barony.ac.uk/artefact/file/profileicons.php

 , referer: http://mahara.barony.ac.uk/artefact/file/profileicons.php

[Melissa Draper (melissa)]

Hi Ali,

I can't reproduce this, so I'll need more information from you.

Are there other errors? That looks like an incomplete stacktrace, look for something that says "fatal".

Also, could you check the logs for the database?

Thanks,
Melissa.

[Gregor Anželj (gregor-anzelj)]

The problem is when Mahara database uses prefix for the tables. If there is no prefix, there is no problem...

The SQL that causes the problems can be found in {mahararoot}/artefact/file/profileicons.json.php.
The problems are in lines 35 and 36 which are:

LEFT OUTER JOIN view_artefact va ON va.artefact = a.id
LEFT OUTER JOIN artefact_attachment aa ON aa.attachment = a.id

but should be (notice the curly brackets around table names!):

LEFT OUTER JOIN {view_artefact} va ON va.artefact = a.id
LEFT OUTER JOIN {artefact_attachment} aa ON aa.attachment = a.id

[Ali Hastie (ahastie)]

Excellent Gregor! That works for me and allows the students to upload profile images too.

Many thanks.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1844
Committed: http://gitorious.org/mahara/mahara/commit/bd68573803233c29bb5e2445d9aef15568b033a2
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit bd68573803233c29bb5e2445d9aef15568b033a2
Author: Gregor Anzelj <email address hidden>
Date: Tue Nov 13 12:55:00 2012 +0100

    Escape table names in profile image query (Bug #1077013)

    When not escaped, the adodb abstraction layer did not use the prefix

    Change-Id: Id44f520e2331be7f3e322f2084412d0b3545701c
    Signed-off-by: Gregor Anzelj <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1838
Committed: http://gitorious.org/mahara/mahara/commit/63395f248d2086e1a64a4f037209d22f60786acb
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit 63395f248d2086e1a64a4f037209d22f60786acb
Author: Gregor Anzelj <email address hidden>
Date: Tue Nov 13 12:55:00 2012 +0100

    Escape table names in profile image query (Bug #1077013)

    When not escaped, the adodb abstraction layer did not use the prefix

    Change-Id: Id44f520e2331be7f3e322f2084412d0b3545701c
    Signed-off-by: Gregor Anzelj <email address hidden>